Skip to content

chore: update 31 #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025
Merged

chore: update 31 #293

merged 3 commits into from
Apr 16, 2025

Conversation

tac0turtle
Copy link
Contributor

Overview

This update is around staking reward withdraw addresses. Due to the requirement that staking rewards must adhere to their vesting schedule it is required to keep the original delegation address as the withdraw address.

cips/cip-031.md Outdated
@@ -157,6 +157,8 @@ When upgrading to v4 we propose introducing a migration that will set the Parame

The continuous and delayed vesting account types will be updated to implement CIP-31. Specifically, they will implement the `UpdateSchedule` function so that the original vesting amount can account for staking rewards. The periodic and permanent account types will not support CIP-31. They will be disallowed from being created.

When delegating an account has the option to set another withdraw address, due to rewards needing to adhere to the original vesting schedule the withdraw address must be the same as the delegator address. This is to ensure that the rewards are locked up in the same account.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When delegating an account has the option to set another withdraw address

I think a user can send MsgSetWithdrawAddress after delegating so perhaps this can be rephrased to:

Accounts can set a withdraw address via MsgSetWithdrawAddress. Due to rewards...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to rewards needing to adhere to the original vesting schedule the withdraw address must be the same as the delegator address

How can we enforce this for vesting accounts that have already delegated and set a withdraw address? Perhaps this should be rephrased to say something like: "vesting accounts that have already delegated and set a withdraw address different from the vesting account address will not receive rewards. Instead the vesting account will receive rewards"

Co-authored-by: Rootul P <[email protected]>
@rootulp rootulp merged commit 371b911 into celestiaorg:main Apr 16, 2025
1 check failed
@tac0turtle tac0turtle deleted the marko/update-31 branch April 16, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants