Skip to content

chore: update 31 #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025
Merged

chore: update 31 #293

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d270921
update 31 for withdraw address
tac0turtle Apr 16, 2025
058281b
reword
tac0turtle Apr 16, 2025
8b163e6
Update cips/cip-031.md
tac0turtle Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cips/cip-031.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,8 @@ When upgrading to v4 we propose introducing a migration that will set the Parame

The continuous and delayed vesting account types will be updated to implement CIP-31. Specifically, they will implement the `UpdateSchedule` function so that the original vesting amount can account for staking rewards. The periodic and permanent account types will not support CIP-31. They will be disallowed from being created.

When delegating an account has the option to set another withdraw address, due to rewards needing to adhere to the original vesting schedule the withdraw address must be the same as the delegator address. This is to ensure that the rewards are locked up in the same account.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When delegating an account has the option to set another withdraw address

I think a user can send MsgSetWithdrawAddress after delegating so perhaps this can be rephrased to:

Accounts can set a withdraw address via MsgSetWithdrawAddress. Due to rewards...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to rewards needing to adhere to the original vesting schedule the withdraw address must be the same as the delegator address

How can we enforce this for vesting accounts that have already delegated and set a withdraw address? Perhaps this should be rephrased to say something like: "vesting accounts that have already delegated and set a withdraw address different from the vesting account address will not receive rewards. Instead the vesting account will receive rewards"


## Test Cases

The implementation should include test cases covering:
Expand Down