feat(cel-shed): datastore: erase samples #4146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new cel-shed command allows erasing samples and relevant daser/availability/pruning states. I needed this to resample, but without spending hours on resyncing headers and I believe this is gonna be useful for us. Besides, I added a command to delete a single arbitary namespace as opposed to a constant group of namespace.
Wondertan
requested review from
renaynay,
vgonkivs,
walldiss and
cristaloleg
as code owners
renaynay
reviewed
Mar 6, 2025
| } | ||
|
|
||
| var eraseCmd = &cobra.Command{ | ||
| Use: "erase <ds_key>", |
There was a problem hiding this comment.
Why need the discover stopped? Why can't they pass either --node.store or --p2p.network to make it more explicit and versatile cmd?
There was a problem hiding this comment.
It should have both, so you can be lazy by not specifying those, but also can override if use non default path
There was a problem hiding this comment.
I personally have multiple types of nodes for multiple networks. Would appreciate an option to specify network name + type of the node in this command. And only network for command of erasing samples
Wondertan
commented
Mar 11, 2025
Comment on lines
+63
to
+65
| ds.NewKey("sampling_result"), | ||
| ds.NewKey("das"), | ||
| ds.NewKey("pruner"), |
There was a problem hiding this comment.
TODO: Make those importable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new cel-shed command allows erasing samples and relevant daser/availability/pruning states. I needed this to resample, but without wasting hours on resyncing headers, and I believe this is gonna be useful for us.
Besides, I added a command to delete a single arbitrary namespace as opposed to a constant group of namespace.
Tested manually.