-
Notifications
You must be signed in to change notification settings - Fork 992
feat(cel-shed): datastore: erase samples #4146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Wondertan
wants to merge
2
commits into
main
Choose a base branch
from
cel-shed/erase-samples
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,134 @@ | ||
package main | ||
|
||
import ( | ||
"context" | ||
"errors" | ||
"fmt" | ||
|
||
"github.com/ipfs/boxo/blockstore" | ||
ds "github.com/ipfs/go-datastore" | ||
"github.com/ipfs/go-datastore/namespace" | ||
dsq "github.com/ipfs/go-datastore/query" | ||
"github.com/spf13/cobra" | ||
"golang.org/x/sync/errgroup" | ||
|
||
"github.com/celestiaorg/celestia-node/nodebuilder" | ||
) | ||
|
||
func init() { | ||
datastoreCmd.AddCommand(eraseCmd, eraseSamplesCmd) | ||
} | ||
|
||
var datastoreCmd = &cobra.Command{ | ||
Use: "datastore [subcommand]", | ||
Short: "Collection of datastore related utilities", | ||
} | ||
|
||
var eraseCmd = &cobra.Command{ | ||
Use: "erase <ds_key>", | ||
Short: "Erase datastore namespace", | ||
RunE: func(cmd *cobra.Command, args []string) error { | ||
path, err := nodebuilder.DiscoverStopped() | ||
if err != nil { | ||
return fmt.Errorf("discovering stopped node: %w", err) | ||
} | ||
fmt.Printf("Discovered stopped node at %s\n", path) | ||
|
||
nodestore, err := nodebuilder.OpenStore(path, nil) | ||
if err != nil { | ||
return err | ||
} | ||
defer func() { | ||
err = errors.Join(err, nodestore.Close()) | ||
}() | ||
|
||
store, err := nodestore.Datastore() | ||
if err != nil { | ||
return fmt.Errorf("getting datastore: %w", err) | ||
} | ||
|
||
key := ds.NewKey(args[0]) | ||
err = eraseDatastoreNamespace(cmd.Context(), store, key) | ||
if err != nil { | ||
return fmt.Errorf("erasing datastore namespace: %w", err) | ||
} | ||
|
||
fmt.Printf("Erased %s\n", key) | ||
return nil | ||
}, | ||
Args: cobra.ExactArgs(1), | ||
} | ||
|
||
var sampleDataKeys = []ds.Key{ | ||
ds.NewKey("sampling_result"), | ||
ds.NewKey("das"), | ||
ds.NewKey("pruner"), | ||
Comment on lines
+63
to
+65
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TODO: Make those importable |
||
blockstore.BlockPrefix, | ||
} | ||
|
||
var eraseSamplesCmd = &cobra.Command{ | ||
Use: "erase-samples [subcommand]", | ||
Short: "Erase samples data and state. Useful to resample, avoiding resyncing headers", | ||
RunE: func(cmd *cobra.Command, _ []string) error { | ||
path, err := nodebuilder.DiscoverStopped() | ||
if err != nil { | ||
return fmt.Errorf("discovering stopped node: %w", err) | ||
} | ||
fmt.Printf("Discovered stopped node at %s\n", path) | ||
|
||
nodestore, err := nodebuilder.OpenStore(path, nil) | ||
if err != nil { | ||
return err | ||
} | ||
defer func() { | ||
err = errors.Join(err, nodestore.Close()) | ||
}() | ||
|
||
ds, err := nodestore.Datastore() | ||
if err != nil { | ||
return fmt.Errorf("getting datastore: %w", err) | ||
} | ||
|
||
group, ctx := errgroup.WithContext(cmd.Context()) | ||
for _, key := range sampleDataKeys { | ||
group.Go(func() error { | ||
err := eraseDatastoreNamespace(ctx, ds, key) | ||
if err != nil { | ||
return fmt.Errorf("erasing datastore namespace: %w", err) | ||
} | ||
fmt.Printf("Erased %s\n", key) | ||
return nil | ||
}) | ||
} | ||
|
||
return group.Wait() | ||
}, | ||
} | ||
|
||
func eraseDatastoreNamespace(ctx context.Context, store ds.Datastore, key ds.Key) error { | ||
store = namespace.Wrap(store, key) | ||
|
||
q := dsq.Query{KeysOnly: true} | ||
res, err := store.Query(ctx, q) | ||
if err != nil { | ||
return fmt.Errorf("querying datastore: %w", err) | ||
} | ||
|
||
for { | ||
e, ok := res.NextSync() | ||
if !ok { | ||
break | ||
} | ||
if e.Error != nil { | ||
return fmt.Errorf("getting next key: %w", e.Error) | ||
} | ||
|
||
key := ds.RawKey(e.Key) | ||
err := store.Delete(ctx, key) | ||
if err != nil { | ||
return fmt.Errorf("deleting key: %w", err) | ||
} | ||
} | ||
|
||
return nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why need the discover stopped? Why can't they pass either
--node.store
or--p2p.network
to make it more explicit and versatile cmd?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should have both, so you can be lazy by not specifying those, but also can override if use non default path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally have multiple types of nodes for multiple networks. Would appreciate an option to specify network name + type of the node in this command. And only network for command of erasing samples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's TBD