fix for cmake 4 #1532
fix for cmake 4 #1532
Conversation
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required (VERSION 3.2.0) | |||
| cmake_minimum_required (VERSION 3.2.0...3.5) | |||
There was a problem hiding this comment.
The main Cemu cmake uses 3.21.1 as the minimum, it would make more sense to use the same one for this
| cmake_minimum_required (VERSION 3.2.0...3.5) | |
| cmake_minimum_required (VERSION 3.21.1) |
There was a problem hiding this comment.
No, it would not. discord-rpc has not been updated in a while, and its CMakeLists.txt file probably uses outdated policies and quirks from old CMake version. So CMake should be configured to act as it was in version 3.5 (the minimum supported version in recent CMake releases).
There was a problem hiding this comment.
Its CMakeLists.txt file quite literally uses 7 commands, none of which are tied to any outdated feature of earlier versions of CMake.. (which are kind of poorly written anyway imo)
Either way it would work fine under 3.21, and it shouldn't be less than the base project in order to not have an issue like this again later.
Compatibility with versions of CMake older than 3.5 has been removed.