Skip to content

fix for cmake 4 #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix for cmake 4 #1532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dependencies/discord-rpc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required (VERSION 3.2.0)
cmake_minimum_required (VERSION 3.2.0...3.5)
project (DiscordRPC)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main Cemu cmake uses 3.21.1 as the minimum, it would make more sense to use the same one for this

Suggested change
cmake_minimum_required (VERSION 3.2.0...3.5)
cmake_minimum_required (VERSION 3.21.1)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it would not. discord-rpc has not been updated in a while, and its CMakeLists.txt file probably uses outdated policies and quirks from old CMake version. So CMake should be configured to act as it was in version 3.5 (the minimum supported version in recent CMake releases).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its CMakeLists.txt file quite literally uses 7 commands, none of which are tied to any outdated feature of earlier versions of CMake.. (which are kind of poorly written anyway imo)
Either way it would work fine under 3.21, and it shouldn't be less than the base project in order to not have an issue like this again later.


include(GNUInstallDirs)
Expand Down
Loading