Deprioritize resync operations#728
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @alandiegosantos. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
In this controller, the resync of the istio-ca-root configmap is not a priority compared with the events derived from namespace operations or change in the root CA. The resync operation also impacts clusters with thousands of namespaces, taking tenths of minutes to loop through all the configmaps, slowing the provisioning of the configmap on new namespaces. So, this MR updates the controller to use WithLowPriorityWhenUnchanged, reducing the priority of the resync if the configmap is unchanged. The PriorityQueue are default in controller-runtime v0.23, so no other change is necessary. Signed-off-by: Alan Diego dos Santos <alandiegosantos@gmail.com>
1b53173 to
6d1af78
Compare
In this controller, the re-sync of the istio-ca-root configmap is not a priority compared with the events derived from namespace operations or the change in the root CA. The resync might take tenths of minutes in clusters with thousands of namespaces, slowing the provisioning of the configmap on new namespaces.
So, this MR updates the controller to use WithLowPriorityWhenUnchanged, reducing the priority of the re-sync if the configmap is unchanged. PriorityQueues are default in controller-runtime v0.23, so no other change is necessary.