Skip to content

Deprioritize resync operations #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alandiegosantos wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Deprioritize resync operations #728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions pkg/controller/configmap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,17 @@ func AddConfigMapController(ctx context.Context, log logr.Logger, opts Options)
}

return ctrl.NewControllerManagedBy(opts.Manager).
// Reconcile ConfigMaps but only cache metadata
For(new(corev1.ConfigMap), builder.OnlyMetadata, builder.WithPredicates(predicate.NewPredicateFuncs(func(obj client.Object) bool {
// Only process ConfigMaps with the istio configmap name
return obj.GetName() == configMapNameIstioRoot
}))).
// Reconcile ConfigMaps but only cache metadata.
// Use WithLowPriorityWhenUnchanged to deprioritize events from initial list sync and resyncs.
Watches(
&corev1.ConfigMap{},
handler.WithLowPriorityWhenUnchanged(&handler.EnqueueRequestForObject{}),
builder.OnlyMetadata,
builder.WithPredicates(predicate.NewPredicateFuncs(func(obj client.Object) bool {
// Only process ConfigMaps with the istio configmap name
return obj.GetName() == configMapNameIstioRoot
})),
).

// Watch all Namespaces. Cache whole Namespace to include Phase Status.
Watches(&corev1.Namespace{}, handler.EnqueueRequestsFromMapFunc(
Expand Down