Token urls - #38
Conversation
willbarton
left a comment
There was a problem hiding this comment.
One quick thing at a glance, but this looks really cool!
|
I have rebased from upstream master to resolve CI complaints. |
|
@tombola another rebase? would be great to get this in an official release |
|
After rebasing I am not quite sure why this is failing. There is an invocation error for tox and coverage is asking for a token, @willbarton does this relate to a recent upstream change perhaps? |
|
@tombola it looks like you've got an import order linting failure in a couple of spots and it looks like we need to include |
|
@willbarton this one got away from me, and realistically I am not going to be able to look at it anytime soon, feel free to close if necessary. |
Uses a token based URL to allow the sharing link to be a publically accessible (unguessable) URL, so that the content can be reviewed by someone outside of organisation/network.
Additions
Todos
Checklist
Code follows the standards laid out in the front end playbookPlaceholder code is flaggedVisually tested in supported browsers and devices