Skip to content

Token urls - #38

Closed
tombola wants to merge 6 commits into
cfpb:mainfrom
tombola:token-urls
Closed

Token urls#38
tombola wants to merge 6 commits into
cfpb:mainfrom
tombola:token-urls

Conversation

@tombola

@tombola tombola commented Aug 12, 2020

Copy link
Copy Markdown

Uses a token based URL to allow the sharing link to be a publically accessible (unguessable) URL, so that the content can be reviewed by someone outside of organisation/network.

Additions

  • Option to use a token based url to share content rather than the same wagtail path at the sharing site

Todos

  • Add tests for token creation and view

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@willbarton willbarton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick thing at a glance, but this looks really cool!

Comment thread CONTRIBUTING.md
@tombola

tombola commented Aug 14, 2020

Copy link
Copy Markdown
Author

I have rebased from upstream master to resolve CI complaints.

@willbarton
willbarton changed the base branch from master to main August 20, 2020 16:05
@zerolab

zerolab commented Dec 8, 2020

Copy link
Copy Markdown

@tombola another rebase? would be great to get this in an official release

@tombola

tombola commented Dec 9, 2020

Copy link
Copy Markdown
Author

After rebasing I am not quite sure why this is failing.

There is an invocation error for tox and coverage is asking for a token, @willbarton does this relate to a recent upstream change perhaps?

@willbarton

willbarton commented Dec 9, 2020

Copy link
Copy Markdown
Member

@tombola it looks like you've got an import order linting failure in a couple of spots and it looks like we need to include GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} in this section of our GitHub actions. For that last one, you just need another rebase. Sorry about that!

@tombola

tombola commented Oct 25, 2021

Copy link
Copy Markdown
Author

@willbarton this one got away from me, and realistically I am not going to be able to look at it anytime soon, feel free to close if necessary.

@zerolab zerolab mentioned this pull request Oct 25, 2021
@tombola

tombola commented Nov 22, 2021

Copy link
Copy Markdown
Author

Closed in favour of #47, thanks @zerolab

@tombola tombola closed this Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants