[pull] master from microsoft:master#103
Merged
Merged
Conversation
The fileHandle obtained from CreateFileW was never closed after calling GetFinalPathNameByHandleW, leaking a kernel handle on every invocation. Add CloseHandle(fileHandle) on both the success path and the error path before die(). Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
Add patch from libgit2/libgit2#7200 to vcpkg overlay. Allows non-elevated processes run by Administrators group members to be considered the owner of repositories owned by that group. Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
…mount TryUpdateHooks (called at mount time) updated the 3 native hooks (read-object, virtual-filesystem, post-index-change) but skipped the pre-command.exe and post-command.exe copies of GitHooksLoader.exe. Those were only deployed at clone time via InstallHooks, so upgrading GVFS and remounting left stale loader binaries in the enlistment. Refactor TryUpdateHook into an overload that takes explicit source and target paths, then call it from TryUpdateHooks for both command hook loaders using GitHooksLoader.exe as the source. The HookData overload becomes a thin wrapper that delegates to the new one. Add Assert-HookVersionsMatch to the staging-upgrade and clean-upgrade test scenarios: after upgrade completes, remount and verify all 5 hook binaries match the installed versions. Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
Transient failures in actions/download-artifact are a frequent source of flaky CI runs. Add a retry step after each download that triggers only when the first attempt fails (continue-on-error + outcome check). Applied to both functional-tests.yaml and upgrade-tests.yaml. Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
upgrade-tests: verify hook binary versions after upgrade+remount
Add non-elevated admin owner patch to libgit2 overlay
ci: add retry for artifact download steps
…lpathname Fix handle leak in GetFinalPathName
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )