Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59db890b4e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| }, | ||
| { | ||
| "coinDenom": "NBTC", | ||
| "coinMinimalDenom": "ibc/75345531D87BD90BF108BE7240BD721CB2CB0A1F16D4EBA71B09EC3C43E15C8F", |
There was a problem hiding this comment.
currencies
I checked the repo validator and PR workflow: .github/workflows/pull-request-validation.yml:35-40 runs src/index.ts on every changed JSON file, and checkCurrencies in src/validate.ts:283-328 rejects ibc/* entries on Osmosis unless they match one of four hard-coded exceptions. ibc/75345531D87BD90BF108BE7240BD721CB2CB0A1F16D4EBA71B09EC3C43E15C8F is not one of those exceptions, so this change makes cosmos/osmosis.json fail validation unless the validator is updated in the same commit.
Useful? React with 👍 / 👎.
| "coinDenom": "NBTC", | ||
| "coinMinimalDenom": "ibc/75345531D87BD90BF108BE7240BD721CB2CB0A1F16D4EBA71B09EC3C43E15C8F", | ||
| "coinDecimals": 15, | ||
| "coinImageUrl": "https://raw.githubusercontent.com/chainapsis/keplr-chain-registry/main/images/osmosis/ibc/75345531D87BD90BF108BE7240BD721CB2CB0A1F16D4EBA71B09EC3C43E15C8F.png" |
There was a problem hiding this comment.
This coinImageUrl references the newly added images/osmosis/ibc/75345531D87BD90BF108BE7240BD721CB2CB0A1F16D4EBA71B09EC3C43E15C8F.png, whose PNG header reports 751×751. The repo requires 256×256 token icons (README.md:331), and checkImageSize in src/validate.ts:221-227 enforces that for every referenced image, so validation will still fail even if the denom entry itself is accepted.
Useful? React with 👍 / 👎.
1 participant
Changes
Checklist
yarn validate <your-config-file>locally, and it passed without any errors.