Skip to content

add nBTC to osmosis #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nostradamus411 wants to merge 1 commit into from
Closed

add nBTC to osmosis #1430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cosmos/osmosis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,13 @@
"coinMinimalDenom": "factory/osmo1x7s7a2erqspkm6e79n7yh7fw3yh7xx4lt54mxg/uquark",
"coinDecimals": 6,
"coinImageUrl": "https://raw.githubusercontent.com/chainapsis/keplr-chain-registry/main/images/osmosis/factory/osmo1x7s7a2erqspkm6e79n7yh7fw3yh7xx4lt54mxg/uquark.png"
}
},
{
"coinDenom": "NBTC",
"coinMinimalDenom": "ibc/75345531D87BD90BF108BE7240BD721CB2CB0A1F16D4EBA71B09EC3C43E15C8F",
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Don't add a new IBC denom to Osmosis currencies

I checked the repo validator and PR workflow: .github/workflows/pull-request-validation.yml:35-40 runs src/index.ts on every changed JSON file, and checkCurrencies in src/validate.ts:283-328 rejects ibc/* entries on Osmosis unless they match one of four hard-coded exceptions. ibc/75345531D87BD90BF108BE7240BD721CB2CB0A1F16D4EBA71B09EC3C43E15C8F is not one of those exceptions, so this change makes cosmos/osmosis.json fail validation unless the validator is updated in the same commit.

Useful? React with 👍 / 👎.

"coinDecimals": 15,
"coinImageUrl": "https://raw.githubusercontent.com/chainapsis/keplr-chain-registry/main/images/osmosis/ibc/75345531D87BD90BF108BE7240BD721CB2CB0A1F16D4EBA71B09EC3C43E15C8F.png"
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Replace the nBTC icon with a 256×256 PNG

This coinImageUrl references the newly added images/osmosis/ibc/75345531D87BD90BF108BE7240BD721CB2CB0A1F16D4EBA71B09EC3C43E15C8F.png, whose PNG header reports 751×751. The repo requires 256×256 token icons (README.md:331), and checkImageSize in src/validate.ts:221-227 enforces that for every referenced image, so validation will still fail even if the denom entry itself is accepted.

Useful? React with 👍 / 👎.

}
],
"feeCurrencies": [
{
Expand Down
Binary file added ...smosis/ibc/75345531D87BD90BF108BE7240BD721CB2CB0A1F16D4EBA71B09EC3C43E15C8F.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading