fix(bitcoin-da): return MempoolSpaceRequestError on HTTP failure in get_fee_rate_from_mempool_space#3226
Open
amathxbt wants to merge 2 commits into
Open
Conversation
…t failure get_fee_rate_from_mempool_space was mapping reqwest::Error (a network-level failure such as a timeout or connection refused) to MempoolSpaceParseError instead of MempoolSpaceRequestError. This made it impossible for callers to distinguish between a failed HTTP request and a JSON parse error, and wasted the existing From<reqwest::Error> impl on MempoolSpaceRequestError. Fix: use MempoolSpaceRequestError(e) in the map_err on get_with_timeout.
jfldde
approved these changes
Apr 30, 2026
Author
|
@jfldde @eyusufatik — this PR is approved and ready. No lint issues found. Pinging for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_fee_rate_from_mempool_spacemaps a network-levelreqwest::Error(timeout, connection refused, DNS failure, etc.) toFeeServiceError::MempoolSpaceParseErrorinstead ofFeeServiceError::MempoolSpaceRequestError.Bug
MempoolSpaceParseErroris intended for JSON deserialization failures. Using it here:#[from] reqwest::Errorimpl onMempoolSpaceRequestError, which was added precisely for this case.Fix
Use the correct variant so the two failure modes are distinguishable:
Files changed
crates/bitcoin-da/src/fee.rs