Skip to content

fix(bitcoin-da): return MempoolSpaceRequestError on HTTP failure in get_fee_rate_from_mempool_space #3226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amathxbt wants to merge 2 commits into
base: nightly
Choose a base branch
from
Open

fix(bitcoin-da): return MempoolSpaceRequestError on HTTP failure in get_fee_rate_from_mempool_space #3226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dbd8b5
fix(bitcoin-da): return correct error variant on mempool.space reques…
amathxbt Apr 30, 2026
2614349
chore: add CHANGELOG entry for #3226
amathxbt Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
### Changed
- perf: Mine reveal prefix relying on `sign_schnorr` internal randomness.([#3192](https://github.com/chainwayxyz/citrea/pull/3192))
- fix: use deterministic boundless patch and unpin ubuntu ci.([#3216](https://github.com/chainwayxyz/citrea/pull/3216))
- fix(bitcoin-da): return correct error variant on mempool.space HTTP request failure. ([#3226](https://github.com/chainwayxyz/citrea/pull/3226))

## [v2.3.1](2026-03-31)

Expand Down
2 changes: 1 addition & 1 deletion crates/bitcoin-da/src/fee.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ pub(crate) async fn get_fee_rate_from_mempool_space(mempool_space_url: &str) ->
.await
.map_err(|e| {
trace!("Failed to fetch from {}: {:?}", url, e);
FeeServiceError::MempoolSpaceParseError
FeeServiceError::MempoolSpaceRequestError(e)
})?;

let json = response.json::<serde_json::Value>().await.map_err(|e| {
Expand Down