Refine Menu Toggle Styling & Fix Toolbar Input Alignment #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jenny <[email protected]> apply MUI dialog styling to PF modal Signed-off-by: Jenny <[email protected]> fix label UI bug, remove scrollbar inset fix select menu theming Signed-off-by: Jenny <[email protected]> fix sidebar height
Signed-off-by: Alessio Pragliola <[email protected]>
…ui/bff (kubeflow#990) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.34.0 to 0.38.0. - [Commits](golang/net@v0.34.0...v0.38.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-version: 0.38.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…_token) (kubeflow#918) * feat(bff): introduce support of multiple auth methods (internal, user_token) - Introduce auth-method flag (default: internal) to select auth strategy - internal: uses pod service account (in-cluster) or current kubeconfig (local) - user_token: uses bearer token from X-Forwarded-Access-Token header - Implement separate SAR (internal) and SSAR (user_token) logic - Clarify behavior and usage in README Signed-off-by: Eder Ignatowicz <[email protected]> * feat(bff): looks like we don't need to override the certs Signed-off-by: Eder Ignatowicz <[email protected]> * Fixes after code review by Christian Signed-off-by: Eder Ignatowicz <[email protected]> * fixing mock factory creation (removing real client creation but still reuse methods) Signed-off-by: Eder Ignatowicz <[email protected]> * Adding back clusterAdmin to user, implement it to token, and also extract user name in token case Signed-off-by: Eder Ignatowicz <[email protected]> * feat(auth): make token header and prefix configurable via flags and env - Introduced `AuthTokenHeader` and `AuthTokenPrefix` fields to EnvConfig - Default token extraction uses `Authorization` header with `Bearer ` prefix - Updated TokenClientFactory to dynamically parse token using configured header and prefix - Added new CLI flags: `--auth-token-header` and `--auth-token-prefix` - Updated Makefile to support overriding header and prefix via `AUTH_TOKEN_HEADER` and `AUTH_TOKEN_PREFIX` - Improved error messages and testability of token parsing logic - Added Ginkgo unit tests for TokenClientFactory.ExtractRequestIdentity with and without prefixes - Cleaned up README: - Replaced all `X-Forwarded-Access-Token` references with `Authorization: Bearer` - Documented how to override token header and prefix via CLI, env, or Makefile Signed-off-by: Eder Ignatowicz <[email protected]> --------- Signed-off-by: Eder Ignatowicz <[email protected]>
* fix(python-e2e): clean up port forwards after tests run Signed-off-by: Eric Dobroveanu <[email protected]> * chore: add pid file to gitignore Signed-off-by: Eric Dobroveanu <[email protected]> * chore: ensure CI correctly forwards the local registry port Signed-off-by: Eric Dobroveanu <[email protected]> --------- Signed-off-by: Eric Dobroveanu <[email protected]>
CPU limits are largely unnecessary because pods are guaranteed their CPU request, and unused CPU time on the node might as well go to bursting pods. Signed-off-by: Paul Boyd <[email protected]>
Signed-off-by: Alessio Pragliola <[email protected]>
…low#987) * fix: ensure model+ver does not already exist Signed-off-by: syntaxsdev <[email protected]> * fix: add test case and refactored logic Signed-off-by: syntaxsdev <[email protected]> * refactor: format/linting Signed-off-by: syntaxsdev <[email protected]> * refactor: format Signed-off-by: syntaxsdev <[email protected]> * format: fix import org Signed-off-by: syntaxsdev <[email protected]> --------- Signed-off-by: syntaxsdev <[email protected]>
Signed-off-by: Chandana Sirigineedi <[email protected]>
3 tasks
|
See kubeflow#989 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your styling contribution @chandanasirigineedi !
This PR includes a few additional refinements:
I've replaced hardcoded hex values with theme variables (
var(--mui-palette-*)) to maintain consistency with our theming approach and make future updates easier when core colors change.