Skip to content

Fix Toolbar Alignment in Model Registry UI #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chandanasirigineedi
Copy link
Contributor

@chandanasirigineedi chandanasirigineedi commented Apr 16, 2025

Description

Corrected alignment issues on the Model Registry page #931

How Has This Been Tested?

Locally Tested UI with Mock Backend

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • [ X] The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • [ X] The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • [ X] For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • [ X] Included any necessary screenshots or gifs if it was a UI change.
  • [ X] Verify that UI/UX changes conform the UX guidelines for Kubeflow.
    image

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Chandana Sirigineedi <[email protected]>
@chandanasirigineedi chandanasirigineedi changed the title Fixing Alignment to menu Toggle Component Fixing Alignment of Menu Toggle Component in Model Registry Page Apr 17, 2025
@chandanasirigineedi chandanasirigineedi changed the title Fixing Alignment of Menu Toggle Component in Model Registry Page Fixing Toolbar Alignment in Model Registry Page Apr 17, 2025
@chandanasirigineedi chandanasirigineedi changed the title Fixing Toolbar Alignment in Model Registry Page Fix Toolbar Alignment in Model Registry Page Apr 17, 2025
@chandanasirigineedi
Copy link
Contributor Author

chandanasirigineedi commented Apr 17, 2025

cc @Al-Pragliola @andreyvelich Can you guys take a look at it, please?

@chandanasirigineedi chandanasirigineedi changed the title Fix Toolbar Alignment in Model Registry Page Fix Toolbar Alignment in Model Registry UI Apr 17, 2025
@jenny-s51
Copy link
Member

/assign

@jenny-s51
Copy link
Member

jenny-s51 commented Apr 17, 2025

Thanks for your PR @chandanasirigineedi 🎉 I will pull it down and take a look!

@jenny-s51
Copy link
Member

@chandanasirigineedi I PR-ed your PR with some additional refinements here. Can you sync your branch with the latest changes on main before you approve/merge? Thanks!

@chandanasirigineedi
Copy link
Contributor Author

@jenny-s51 Thank you I’ll update my branch and review again shortly.

@ederign
Copy link
Member

ederign commented Apr 21, 2025

/assign @jenny-s51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants