-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[misc] scib-metrics scripts #945
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #945 +/- ##
==========================================
+ Coverage 91.11% 91.26% +0.14%
==========================================
Files 77 80 +3
Lines 5922 6330 +408
==========================================
+ Hits 5396 5777 +381
- Misses 526 553 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3f55e66
to
1e059ca
Compare
…rg/cell-census into ebezzi/scib-metrics-scripts
This PR has not seen any activity in the past 4 weeks; if no one comments or reviews it in the next 3 days, this PR will be closed. |
@ebezzi is there a distinct |
No, if I recall correctly, you're just supposed to call the script with the config file as a parameter. The one included here should be fine. We can delete that if branch. |
try: | ||
file = sys.argv[1] | ||
except IndexError: | ||
file = "scib-metrics-config-plot.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ebezzi Isn't there a scib-metrics-config-plot.yaml
not yet checked in here, distinct from scib-metrics-config.yaml
which is checked in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #945 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ebezzi This PR includes one YAML file scib-metrics-config.yaml
which feeds into run-scib.py
, with keys such as census
embeddings
tissues
Here we have a different script run-scib-plots.py
which appears to expect a different YAML file named scib-metrics-config-plot.yaml
with keys such as metrics_files
metrics_plots
decimal_values
normalize_entropy
etc. accessed below.
Did I miss something?
Add a script that can run scib metrics on configurable slices of the Census.