-
Notifications
You must be signed in to change notification settings - Fork 427
Add option to build Chapel with mimalloc as either the host or target allocator #26246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d297385
to
0afe0d9
Compare
321e73d
to
272e0d7
Compare
1d3c286
to
5f86d37
Compare
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Note that adding a new third-party package requires updates to the Also, I hate to bring this up again today, but historically, we've expected changes as major as this to occur after some sort of heads-up or discussion with the team (which, admittedly, I may have simply missed). The way we've summarized this policy in the past has been "Developers shouldn't hear about a major change to the project architecture or capabilities for the first time by reading a PR merge notification." The goal of this policy is to operate by consensus and avoid surprises. |
I opened #27088 to remedy this
This discussion occurred months ago, so there was admittedly a gap between when that occurred and the PR being merged. This gap was caused by factors out of our control. |
Adds the ability to set
CHPL_HOST_MEM
and/orCHPL_TARGET_MEM
tomimalloc
.This PR only provides the option to use mimalloc, it does not change the default from jemalloc
Performance comparisons for
CHPL_TARGET_MEM
on linux64test/performance/memory/microMemoryAllocation.chpl
Using
--trials=2_000_000
test/studies/shootout/binary-trees/binarytrees-inner.chpl
Using
--n=21
Performance comparisons for
CHPL_HOST_MEM
on linux64Compiling examples/hello.chpl
Compiling Arkouda
Major changes in this PR
$CHPL_HOME/third-party/mimalloc
or from the systemCorrectness testing
make check
with/without gasnet with CHPL_TARGET_MEM=mimalloc on MacOSmake check
with/without gasnet with CHPL_HOST_MEM=mimalloc on MacOSFuture work:
[Reviewed by @jhh67]