Implement &&= and ||= in ChapelBase via new primitive #27102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arifthpe
force-pushed
the
logical-assignment-operators
branch
from
f292410 to
40ecf39
Compare
4 tasks
arifthpe
force-pushed
the
logical-assignment-operators
branch
from
40ecf39 to
c50debf
Compare
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
arifthpe
force-pushed
the
logical-assignment-operators
branch
from
744be56 to
1a1ffd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement these compound assignment operators via module code primitive calls, and (trivially) implement those in Dyno.
All other compound assignment ops are already implemented this way, but these were special-cased in
convert-uastto generate a separate op and assign. This PR removes the special casing and adds an analogous implementation in the production compiler.A small parser modification was required to recognize these tokens as assignment operator names (
assignop_ident), so this PR also rebuilds the parser generated files.Also includes adding a Dyno test for resolving calls to these operators.
Resolves https://github.com/Cray/chapel-private/issues/7291.
[reviewer info placeholder]
Testing: