Fix error reporting in sub_test to not confuse JUnit parsing script#28425
Merged
DanilaFe merged 2 commits intochapel-lang:mainfrom Feb 19, 2026
Merged
Fix error reporting in sub_test to not confuse JUnit parsing script#28425DanilaFe merged 2 commits intochapel-lang:mainfrom
sub_test to not confuse JUnit parsing script#28425DanilaFe merged 2 commits intochapel-lang:mainfrom
Conversation
'Error matching sub_test' is a specific line that is expected when a `sub_test` script itself fails. In this instance, it's printed from a `sub_test` script to indicate that the the test failed. This is a distinct failure mode, and is handled better by regular logic that looks for `Error *`. So, change the error to not count as a sub_test failure. Signed-off-by: Danila Fedorin <daniel.fedorin@hpe.com>
DanilaFe
force-pushed
the
improve-subtest-errors
branch
from
e35dce5 to
14b7436
Compare
arifthpe
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(re) closes https://github.com/Cray/chapel-private/issues/3597.
Reverts #28420.
'Error matching sub_test' is a specific line that is expected when a
sub_testscript itself fails. In this instance, it's printed from asub_testscript to indicate that the the test itself failed (as opposed to the script). This is a distinct failure mode, and is handled better by regular logic that looks forError *. So, change the error to not count as a sub_test failure.Reviewed by @arifthpe -- thanks!
Testing