Skip to content

test: add a test for canceling the context #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

caarlos0
Copy link
Member

this adds test for canceling the context within the bubble

Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0 caarlos0 self-assigned this Jan 21, 2025
@desertwitch
Copy link

desertwitch commented Mar 26, 2025

This PR (and included tests) should be obsolete and resolved with the proposed changes in #1372.

The behavior documented in this PR:

// Note that canceling the context from within bubbletea (e.g. in an [Cmd]) is
// not supported.

Actually is a symptom of a deadlock issue described in #1370 and resolved through #1372 (when merged).
By resolving the deadlock issue, cancellation from within bubbletea is possible (as it is from outside and should be).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants