(v1-1/3) tea.go: fix deadlock on context cancellation #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great find @desertwitch! Could you add a test case covering this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1372 +/- ##
=======================================
Coverage ? 69.25%
=======================================
Files ? 17
Lines ? 1698
Branches ? 0
=======================================
Hits ? 1176
Misses ? 474
Partials ? 48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sure - I've added the tests, also squashed and reworded my commits to follow the message convention. 😉 P.S. This resolves the symptom of a program getting stuck on context cancellation from "within" (a model's methods). |
|
closes #1292 |
aymanbagabas
approved these changes
Mar 26, 2025
desertwitch
changed the title
desertwitch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1370
closes #1292
context cancellation causes immediate exit of channel receiving routine handleCommands
select statement wrap prevents deadlocks on eventLoop sends to stale channel and ensures routine exit