Skip to content

fix(lfs): fixed LFS uploading on Windows because of opened file handler#782

Open
maybe-ilya wants to merge 1 commit intocharmbracelet:mainfrom
maybe-ilya:fix/lfs-upload-on-windows
Open

fix(lfs): fixed LFS uploading on Windows because of opened file handler#782
maybe-ilya wants to merge 1 commit intocharmbracelet:mainfrom
maybe-ilya:fix/lfs-upload-on-windows

Conversation

@maybe-ilya
Copy link
Copy Markdown

@maybe-ilya maybe-ilya commented Feb 5, 2026

Steps to reproduce:

  1. Host soft-serve on Windows machine and create minimal working environment
  2. Create empty repo on server
  3. Prepare local repo with some LFS objects (object size doesn't matter) and track them. Or clone one of mine repos
  4. Add remote url from step 2
  5. Try to push

Actual result:
Temporary files from incomplete directory are blocked by t.storage.Open(os.Open) calls and can't be moved to new location.

Should fix #770

  • I have read CONTRIBUTING.md.
  • I have created a discussion that was approved by a maintainer (for new features).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LFS upload reports errors related to locking, either of the database (when using HTTP) or of the files itself

1 participant