Skip to content

fix(lfs): fixed LFS uploading on Windows because of opened file handler #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maybe-ilya wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −3
Open

fix(lfs): fixed LFS uploading on Windows because of opened file handler #782

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions pkg/git/lfs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"errors"
"fmt"
"io"
"io/fs"
"path"
"path/filepath"
"strconv"
Expand Down Expand Up @@ -147,9 +148,15 @@ func (t *lfsTransfer) Upload(oid string, size int64, r io.Reader, _ transfer.Arg
return err
}

obj, err := t.storage.Open(tempName)
exist, err := t.storage.Exists(tempName)
if err != nil {
t.logger.Errorf("error opening object: %v", err)
t.logger.Errorf("error accessing object: %v", err)
return err
}

if !exist {
err = fs.ErrNotExist
t.logger.Errorf("error accessing object: %v %v", err, tempName)
return err
}

Expand All @@ -167,7 +174,7 @@ func (t *lfsTransfer) Upload(oid string, size int64, r io.Reader, _ transfer.Arg
}

expectedPath := path.Join("objects", pointer.RelativePath())
if err := t.storage.Rename(obj.Name(), expectedPath); err != nil {
if err := t.storage.Rename(tempName, expectedPath); err != nil {
t.logger.Errorf("error renaming object: %v", err)
_ = t.store.DeleteLFSObjectByOid(t.ctx, t.dbx, t.repo.ID(), pointer.Oid)
return err
Expand Down