feat(notifications)!: replace Notifications 1.0 with persistent notifications - #1967
Open
hmans wants to merge 40 commits into
Open
feat(notifications)!: replace Notifications 1.0 with persistent notifications#1967hmans wants to merge 40 commits into
hmans wants to merge 40 commits into
Conversation
…-0-details * origin/main: feat(events): add durable pull-worker execution (#1972)
…-0-details * origin/main: perf(core): defer server member detail hydration (#1977) refactor(core): use durable consumers for cleanup (#1974) fix(core): make user key shredding crash-safe (#1973) test(e2e): add large-server performance CI (#1976) # Conflicts: # cli/internal/evtstream/events_integration_test.go # cli/internal/evtstream/incremental_effect_consumer.go # cli/internal/pb/chatto/core/v1/event.pb.go # docs/adr/INDEX.md # docs/architecture/durable-effects.md # docs/architecture/nats-resources.md # docs/architecture/runtime-state.md # docs/fdr/INDEX.md
…-0-details * origin/main: feat(admin): report durable worker health (#1979) # Conflicts: # docs/architecture/durable-effects.md
…-0-details * origin/main: fix(workers): harden durable recovery (#1978) # Conflicts: # docs/architecture/durable-effects.md
…-0-details * origin/main: docs(events): document integration and logging contracts (#2004) fix(events): guard single-run lifecycles (#2003) fix(events): add bounded subject reads (#2002) fix(events): validate snapshot bindings (#2001) fix(events): require pointer projections (#2000) fix(events): make nil loggers safe (#1999) ci: run pull request workflows for stack bases (#1998) feat(auth): add server invite links (#1983) # Conflicts: # apps/frontend/src/lib/api-client-tests/viewer.spec.ts # cli/internal/connectapi/api_contract_test.go # cli/internal/core/projection_wiring.go # cli/internal/evtstream/publisher.go # cli/internal/pb/chatto/core/v1/event.pb.go # docs/adr/INDEX.md # docs/architecture/interfaces.md
…-0-details * origin/main: feat(messages): add pinned channel messages (#1990) # Conflicts: # apps/docs-website/src/content/docs/releases/0-5-0.mdx # cli/internal/pb/chatto/core/v1/event.pb.go # cli/internal/pb/chatto/core/v1/projection_snapshots.pb.go # cli/internal/pb/chatto/realtime/v1/realtime.pb.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Notifications 1.0 coupled attention, handling, and deletion: opening or dismissing an item removed it, and users could not retain read items. Notifications 2.0 replaces it with a persistent notification list whose attention state is independent from deletion.
Closes #1556.
What
RUNTIME_STATE, with a 90-day absolute TTLEVTlimited to domain-changing facts: Notifications 2.0 adds no occurrence, candidate, plan, revocation, authorization-fence, or worker-trigger eventsAPI and compatibility
MarkNotificationRead, and delete operations. The PR carries theapi-breaking-changelabel.NotificationOccurrence.unreadis the public attention state; the public Inbox/Done enum, view filter, general occurrence update, and group-state update are removed.DeleteAllNotificationOccurrencesis additive within the Notifications 2.0 API. It deletes the occurrence set current at the authoritative mutation boundary; clients must not automatically retry after an ambiguous failure because later activity can arrive after that boundary.DONEenum value for protobuf/storage compatibility. Current code treats it as read and never writes it.NotificationServicemethods.Verification
origin/main(2b3b18736)mise codegen-protomise test-climise test-frontend(125 server files / 1,137 tests; 159 client files / 1,596 tests; 60 Storybook files / 180 tests; performance comparison passed)mise lint-frontenddiagnostics passed; focused ESLint passed after the final Svelte reactivity fixmise license-check