fix(attributes): preserve non-boolean hidden attribute values#5074
Open
rururux wants to merge 2 commits intocheeriojs:mainfrom
Open
fix(attributes): preserve non-boolean hidden attribute values#5074rururux wants to merge 2 commits intocheeriojs:mainfrom
hidden attribute values#5074rururux wants to merge 2 commits intocheeriojs:mainfrom
Conversation
1 task
Author
|
@fb55 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #5073
Changes
Previously, the
.attr()method could not correctly retrieve the newly implementeduntil-foundvalue for thehiddenattribute. It would instead return"hidden"orundefineddue to being treated strictly as a boolean attribute.In this fix, I have removed
hiddenfrom therbooleanregex/variable to allow it to be handled as an enumerated attribute.Testing
I have added a test case to ensure that the value of the hidden attribute can be correctly read from elements like
<div hidden="until-found">.