Skip to content

fix(attributes): preserve non-boolean hidden attribute values #5074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rururux wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(attributes): preserve non-boolean hidden attribute values #5074

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43d45cc
fix(attributes): preserve non-boolean `hidden` attribute values
rururux Feb 15, 2026
153afe2
fix(attributes): preserve boolean behavior for `hidden` attribute
rururux Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/api/attributes.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ describe('$(...)', () => {
expect(attr).toBe('autofocus');
});

it('(valid key) : should preserve non-boolean hidden attribute values', () => {
const attr = $('<div hidden="until-found">').attr('hidden');
expect(attr).toBe('until-found');
});

it('(key, value) : should set one attr', () => {
const $pear = $('.pear').attr('id', 'pear');
expect($('#pear')).toHaveLength(1);
Expand Down
2 changes: 1 addition & 1 deletion src/api/attributes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const dataAttrPrefix = 'data-';

// Attributes that are booleans
const rboolean =
/^(?:autofocus|autoplay|async|checked|controls|defer|disabled|hidden|loop|multiple|open|readonly|required|scoped|selected)$/i;
/^(?:autofocus|autoplay|async|checked|controls|defer|disabled|loop|multiple|open|readonly|required|scoped|selected)$/i;
// Matches strings that look like JSON objects or arrays
const rbrace = /^{[^]*}$|^\[[^]*]$/;

Expand Down