omnibus/cli: only match override value against regex for strings #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As of Ruby 3.2, `true =~ /regex/` raises an exception (a NoMethodError for `=~`) instead of returning `nil` (seen in 3.1 and earlier), so using `--override key:true` (and false / nil) fails with an error. Instead of always comparing value against a regular expression, only do it if the value didn't match a known true/false/nil value. This appears to stem from <https://bugs.ruby-lang.org/issues/15231>. Signed-off-by: Noel Cower <[email protected]>
nilium
force-pushed
the
nc/override-nonstring
branch
from
d7bf75a to
a0ee559
Compare
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of Ruby 3.2,
true =~ /regex/raises an exception (a NoMethodError for=~) instead of returningnil(seen in 3.1 and earlier), so using--override key:true(and false / nil) fails with an error. Instead of always comparing value against a regular expression, only do it if the value didn't match a known true/false/nil value.This appears to stem from https://bugs.ruby-lang.org/issues/15231.
Maintainers
Please ensure that you check for:
serial number
corresponding change is reviewed and there is a release plan
corresponding change is reviewed and there is a release plan