Skip to content

omnibus/cli: only match override value against regex for strings #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nilium wants to merge 1 commit into
base: main
Choose a base branch
from
Open

omnibus/cli: only match override value against regex for strings #1160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/omnibus/cli/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,7 @@ def initialize(args, options, config)
if %w{true false nil}.include?(value)
log.debug(log_key) { "Detected #{value.inspect} should be an object" }
value = { "true" => true, "false" => false, "nil" => nil }[value]
end

if value =~ /\A[[:digit:]]+\Z/
elsif value =~ /\A[[:digit:]]+\Z/
log.debug(log_key) { "Detected #{value.inspect} should be an integer" }
value = value.to_i
end
Expand Down