docs: rewrite metrics.md for current EPP subsystems#19
Conversation
The metrics guide claimed all series live under the llm_d_inference_scheduler subsystem, which is now deprecated. Document the current subsystems (llm_d_epp_ for EPP-wide metrics, llm_d_router_epp_ for the embedded kv-cache), mark the legacy dual-emitted prefixes and their replacements, expand the catalog beyond disaggregation to the full request, pool, scheduler, plugin, and data-layer set, and add operator scrape topology (EPP :9090/metrics, model-server data layer, embedded kv-cache on the shared registry). Refs: llm-d#1394 Signed-off-by: ChethanUK <chethanuk@outlook.com>
🤖 CodeAnt AI — Review Status
Updated in place by CodeAnt AI · last 5 reviews |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reached
Next review available in: 55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates and expands the documentation in docs/metrics.md to comprehensively detail the Prometheus metrics exposed by the llm-d-router Endpoint Picker (EPP). It introduces structured sections explaining subsystems and naming prefixes, scrape topologies, deprecated series, and a detailed metrics catalog categorized by functional areas such as flow control, disaggregation, and the KV-cache index. No review comments were provided, so there is no additional feedback to address.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Only recorders that have a deprecated predecessor dual-emit; current-only series (ext_proc, program-aware fairness, encoder cache, kv-cache events) emit a single series. Qualify the sentence so it does not read as universal. Signed-off-by: ChethanUK <chethanuk@outlook.com>
User description
What type of PR is this?
/kind documentation
What this PR does / why we need it:
docs/metrics.mdstated that all metrics live under thellm_d_inference_schedulersubsystem, which is now deprecated after therouter rename and metrics migration. This rewrites the guide against the
current code:
llm_d_epp_is the canonical EPP-wide prefix;llm_d_router_epp_is used only by the embedded llm-d-kv-cache metrics.The legacy prefixes (
llm_d_inference_scheduler_,inference_objective_,inference_pool_,inference_extension_,kvcache_) are deprecated butstill dual-emitted, with a replacement table.
:9090/metricsendpoint(controller-runtime registry), the model-server data-layer scrape, and the
embedded kv-cache metrics that register on the same registry when
indexerConfig.kvBlockIndexConfig.enableMetrics: true(default false) — noseparate kv-cache endpoint.
plugin, data-layer errors, prefix indexer, multimodal, program-aware
fairness, predicted latency, plus the existing flow-control and ext_proc
sections, each with types and labels.
Notes for reviewers on the issue's wording vs the code: the canonical EPP-wide
prefix is
llm_d_epp_*, notllm_d_router_epp_*(which is kv-cache-only); andpd_decision_total/disagg_decision_totalare both currentllm_d_epp_*metrics — the actual deprecation is
llm_d_inference_scheduler_* -> llm_d_epp_*per metric. Every documented metric name was cross-checked againstits registration in
pkg/. The e2e kv-cache metrics assertion (issue item 4)is left as the noted follow-up.
Which issue(s) this PR fixes:
Fixes llm-d#1394
Release note:
CodeAnt-AI Description
Update the metrics guide for the current EPP metrics and scrape setup
What Changed
/metricsendpoint, model-server data-layer metrics, and embedded kv-cache metrics on the shared registrypd_decision_totalbehavior and points readers to the current disaggregation metricImpact
✅ Easier metrics migration✅ Clearer operator scrape setup✅ Fewer mismatches between docs and live metrics💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.