grammar: accept hierarchical_identifier as bind target#4089
Merged
Conversation
The bind_directive rule only matched `bind <identifier> ...` — bind to a module type. IEEE 1800-2017 §23.11 also allows the second form, `bind bind_target_instance bind_instantiation`, where the target is a hierarchical_identifier with an optional bit-select (e.g. `bind $root.top.foo_i bar bound_i (.*)` or `bind top.foo_i bar bound_i (.*)`). Surelog rejected these with "no viable alternative at input 'bind \$root'". Extend bind_directive to accept either a hierarchical_identifier (form 2) or an identifier with an optional `:`-prefixed instance list (form 1). The two alternatives are LL(1)-distinguishable because hierarchical_identifier requires at least one `.identifier` after the first identifier (or the `$root.` prefix), so a bare identifier still goes through the form-1 path. Adds tests/BindHierPath/ covering the `$root.top.foo_i` form (sourced from yosys/tests/bind/hier.sv).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bind_directive rule only matched
bind <identifier> ...— bind to a module type. IEEE 1800-2017 §23.11 also allows the second form,bind bind_target_instance bind_instantiation, where the target is a hierarchical_identifier with an optional bit-select (e.g.bind $root.top.foo_i bar bound_i (.*)orbind top.foo_i bar bound_i (.*)). Surelog rejected these with "no viable alternative at input 'bind $root'".Extend bind_directive to accept either a hierarchical_identifier (form 2) or an identifier with an optional
:-prefixed instance list (form 1). The two alternatives are LL(1)-distinguishable because hierarchical_identifier requires at least one.identifierafter the first identifier (or the$root.prefix), so a bare identifier still goes through the form-1 path.Adds tests/BindHierPath/ covering the
$root.top.foo_iform (sourced from yosys/tests/bind/hier.sv).