-
Notifications
You must be signed in to change notification settings - Fork 8
WIP: Add Multiranges test #582
base: master
Are you sure you want to change the base?
Conversation
| ); | ||
| //logic [7:0] [31:0] rdata_d, rdata_q; | ||
| logic [7:0] a, b, c; | ||
| logic [7:0] d_array[0:3]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an unpacked dimension range is zero-based ([0:N-1]), declare size as [N] instead. [Style: unpacked-ordering] [unpacked-dimensions-range-ordering]
| //logic [7:0] [31:0] rdata_d, rdata_q; | ||
| logic [7:0] a, b, c; | ||
| logic [7:0] d_array[0:3]; | ||
| logic [7:0] e_array[3:0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unpacked dimension range must be declared in big-endian ([0:N-1]) order. Declare zero-based big-endian unpacked dimensions sized as [N]. [Style: unpacked-ordering] [unpacked-dimensions-range-ordering]
| logic [7:0] d_array[0:3]; | ||
| logic [7:0] e_array[3:0]; | ||
|
|
||
| logic [7:0] mult_array_a[3:0][3:0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unpacked dimension range must be declared in big-endian ([0:N-1]) order. Declare zero-based big-endian unpacked dimensions sized as [N]. [Style: unpacked-ordering] [unpacked-dimensions-range-ordering]
| logic [7:0] d_array[0:3]; | ||
| logic [7:0] e_array[3:0]; | ||
|
|
||
| logic [7:0] mult_array_a[3:0][3:0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unpacked dimension range must be declared in big-endian ([0:N-1]) order. Declare zero-based big-endian unpacked dimensions sized as [N]. [Style: unpacked-ordering] [unpacked-dimensions-range-ordering]
| logic [7:0] e_array[3:0]; | ||
|
|
||
| logic [7:0] mult_array_a[3:0][3:0]; | ||
| logic [7:0] mult_array_b[3:0][3:0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unpacked dimension range must be declared in big-endian ([0:N-1]) order. Declare zero-based big-endian unpacked dimensions sized as [N]. [Style: unpacked-ordering] [unpacked-dimensions-range-ordering]
| logic [7:0] mult_array_c[3:0][3:0]; | ||
| logic [7:0] mult_array_d[3:0][3:0]; | ||
|
|
||
| logic packed_mult_array_a[3:0][3:0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unpacked dimension range must be declared in big-endian ([0:N-1]) order. Declare zero-based big-endian unpacked dimensions sized as [N]. [Style: unpacked-ordering] [unpacked-dimensions-range-ordering]
| logic [7:0] mult_array_c[3:0][3:0]; | ||
| logic [7:0] mult_array_d[3:0][3:0]; | ||
|
|
||
| logic packed_mult_array_a[3:0][3:0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unpacked dimension range must be declared in big-endian ([0:N-1]) order. Declare zero-based big-endian unpacked dimensions sized as [N]. [Style: unpacked-ordering] [unpacked-dimensions-range-ordering]
| logic [7:0] mult_array_d[3:0][3:0]; | ||
|
|
||
| logic packed_mult_array_a[3:0][3:0]; | ||
| logic packed_mult_array_b[3:0][3:0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unpacked dimension range must be declared in big-endian ([0:N-1]) order. Declare zero-based big-endian unpacked dimensions sized as [N]. [Style: unpacked-ordering] [unpacked-dimensions-range-ordering]
| logic [7:0] mult_array_d[3:0][3:0]; | ||
|
|
||
| logic packed_mult_array_a[3:0][3:0]; | ||
| logic packed_mult_array_b[3:0][3:0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unpacked dimension range must be declared in big-endian ([0:N-1]) order. Declare zero-based big-endian unpacked dimensions sized as [N]. [Style: unpacked-ordering] [unpacked-dimensions-range-ordering]
tests/Multiranges/top.sv
Outdated
|
|
||
| end | ||
|
|
||
| endmodule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
926489d to
a941831
Compare
| assign f_array[1] = 8'hE; | ||
| assign g_array = f_array; | ||
|
|
||
| if (1'b1 == 1'b1) begin : test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All generate block labels must start with g_ or gen_ [Style: generate-constructs] [generate-label-prefix]
This PR adds test with different types of multirange bit-select/part-select.
It is used to test support for multiranges with uhdm-plugin and upstream yosys.
Signed-off-by: Kamil Rakoczy krakoczy@antmicro.com