Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Conversation

@RRozak
Copy link
Member

@RRozak RRozak commented Dec 31, 2021

No description provided.

@RRozak RRozak requested a review from rkapuscik December 31, 2021 09:01
@@ -0,0 +1,28 @@
package prim_esc_pkg;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [verible-verilog-lint] reported by reviewdog 🐶
Package declaration name must match the file name (ignoring optional "_pkg" file name suffix). declaration: "prim_esc_pkg" vs. basename(file): "top" [Style: file-names] [package-filename]

module nmi_gen
import prim_esc_pkg::*;
#(
localparam int unsigned N_ESC_SEV = 3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [verible-verilog-lint] reported by reviewdog 🐶
Non-type localparam names must be styled with CamelCase [Style: constants] [parameter-name-style]

Signed-off-by: Ryszard Różak <rrozak@antmicro.com>
@RRozak RRozak removed the request for review from rkapuscik December 31, 2021 09:14
Signed-off-by: Ryszard Różak <rrozak@antmicro.com>
@RRozak RRozak requested a review from rkapuscik December 31, 2021 09:25
@RRozak
Copy link
Member Author

RRozak commented Dec 31, 2021

It waits for chipsalliance/Surelog#2365

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants