This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Add UnpackedUnionArray test #683
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryszard Różak <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } my_union_t; | ||
|
|
||
| initial begin | ||
| my_union_t un [9:0]; |
There was a problem hiding this comment.
Unpacked dimension range must be declared in big-endian ([0:N-1]) order. Declare zero-based big-endian unpacked dimensions sized as [N]. [Style: unpacked-ordering] [unpacked-dimensions-range-ordering]
Signed-off-by: Ryszard Różak <[email protected]>
|
Unpacked unions are unsupported by both verilators and both yosys. It's better to wait with the merge until there will be at least one tool that can be tested on it |
tests/UnpackedUnionArray/top.sv
Outdated
| @@ -0,0 +1,12 @@ | |||
| module top1(output logic [3:0] o); | |||
There was a problem hiding this comment.
Declared module does not match the first dot-delimited component of file name: "top" [Style: file-names] [module-filename]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.