add test for bits call on struct #729
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,15 @@ | |||
| module top #( | |||
| localparam paddr_width_p = 2 | |||
There was a problem hiding this comment.
Explicitly define a storage type for every parameter and localparam, (paddr_width_p). [Style: constants] [explicit-parameter-storage-type]
| @@ -0,0 +1,15 @@ | |||
| module top #( | |||
| parameter dims_p = 2, | |||
There was a problem hiding this comment.
Explicitly define a storage type for every parameter and localparam, (dims_p). [Style: constants] [explicit-parameter-storage-type]
| @@ -0,0 +1,15 @@ | |||
| module top #( | |||
| parameter dims_p = 2, | |||
| parameter int cord_markers_pos_p[dims_p:0] = '{ 5, 4, 0 } | |||
There was a problem hiding this comment.
Non-type parameter names must be styled with CamelCase or ALL_CAPS [Style: constants] [parameter-name-style]
| @@ -0,0 +1,15 @@ | |||
| module top #( | |||
| parameter dims_p = 2, | |||
| parameter int cord_markers_pos_p[dims_p:0] = '{ 5, 4, 0 } | |||
There was a problem hiding this comment.
Unpacked dimension range must be declared in big-endian ([0:N-1]) order. Declare zero-based big-endian unpacked dimensions sized as [N]. [Style: unpacked-ordering] [unpacked-dimensions-range-ordering]
| parameter int cord_markers_pos_p[dims_p:0] = '{ 5, 4, 0 } | ||
| ) ( | ||
| ); | ||
| typedef struct packed { |
There was a problem hiding this comment.
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
| ) ( | ||
| ); | ||
| typedef struct packed { | ||
| logic [cord_markers_pos_p[dims_p]-1:0 ] cord; |
There was a problem hiding this comment.
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
| ); | ||
| typedef struct packed { | ||
| logic [cord_markers_pos_p[dims_p]-1:0 ] cord; | ||
| } bsg_wormhole_router_header_s; |
There was a problem hiding this comment.
Struct names have to end with _t [Style: struct-union-conventions] [struct-union-name-style]
1 participant
This tests a case that we've encountered in BlackParrot.