Changing hw/latest to track patch_v1.1 branch in RTL repo #1811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlmahowa-amd
approved these changes
Nov 21, 2024
nquarton
force-pushed
the
hw-latest_track_1_1_branch
branch
from
c9df335 to
60adab4
Compare
nquarton
force-pushed
the
hw-latest_track_1_1_branch
branch
from
60adab4 to
189f384
Compare
jhand2
approved these changes
Mar 12, 2025
jhand2
reviewed
Mar 12, 2025
| @@ -4,7 +4,7 @@ | |||
| [submodule "hw/latest/rtl"] | |||
| path = hw/latest/rtl | |||
| url = https://github.com/chipsalliance/caliptra-rtl | |||
| branch = main | |||
| branch = patch_v1.1 | |||
There was a problem hiding this comment.
lgtm, but I think you may need to commit the branch change so that git knows which commit the submodule is at.
There was a problem hiding this comment.
Can you elaborate on that? The branch does exist in the RTL repo. But I may be misunderstanding something about the submodule behavior here.
There was a problem hiding this comment.
The submodule in main points to 5f85fb4, which is patch_v1.1. Jordan if I'm understanding your comment right then the submodule is already updated.
jlmahowa-amd
approved these changes
Mar 13, 2025
| @@ -4,7 +4,7 @@ | |||
| [submodule "hw/latest/rtl"] | |||
| path = hw/latest/rtl | |||
| url = https://github.com/chipsalliance/caliptra-rtl | |||
| branch = main | |||
| branch = patch_v1.1 | |||
There was a problem hiding this comment.
The submodule in main points to 5f85fb4, which is patch_v1.1. Jordan if I'm understanding your comment right then the submodule is already updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.