Skip to content

ref/builder: condense firmware targets using macros #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ref/builder: condense firmware targets using macros #2059

wants to merge 3 commits into from

Conversation

leongross
Copy link
Member

Introduce the macros fwid and fwid_base to eliminate boilerplate code for the FwId definitions used in the Builder.

@leongross leongross requested a review from Copilot March 28, 2025 13:09
Copilot
Copilot AI reviewed Mar 28, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@leongross leongross marked this pull request as ready for review March 28, 2025 14:16
Copilot

This comment was marked as duplicate.

Sign in to view

@leongross leongross force-pushed the leongross/builder/refactor branch from 379532a to e8df73e Compare March 31, 2025 09:13
@leongross leongross changed the title builder: condense firmware targets using macros ref/builder: condense firmware targets using macros Mar 31, 2025
@leongross leongross requested a review from jhand2 April 10, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@ArthurHeymans ArthurHeymans Awaiting requested review from ArthurHeymans

@mhatrevi mhatrevi Awaiting requested review from mhatrevi

@jhand2 jhand2 Awaiting requested review from jhand2

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@leongross