feat: Refactor errors using macro #2061
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhand2
approved these changes
Mar 31, 2025
jhand2
requested changes
Mar 31, 2025
leongross
force-pushed
the
leongross/unique-error-macros-1.x
branch
from
382eeb9 to
90072bd
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
@jhand2 the ROM is now unmodified, all valaues match. |
Refactor error code definitions based on the macro introduced in eee1a37. Signed-off-by: leongross <[email protected]>
leongross
force-pushed
the
leongross/unique-error-macros-1.x
branch
from
90072bd to
a79383c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor error code definitions based on the macro introduced in eee1a37. This PR can be considered a backport of #1992 for version 1.x