Fix OCP LOCK warm reset test #2878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
requested review from
JohnTraverAmd,
ajisaxena,
korran,
mhatrevi,
rusty1968,
swenson and
vsonims
as code owners
clundin25
force-pushed
the
fix-warm-reset
branch
from
93f49b6 to
4b373f3
Compare
clundin25
requested review from
FerralCoder,
bluegate010,
fdamato,
jhand2,
jlmahowa-amd,
nquarton,
wmaroneAMD and
zhalvorsen
as code owners
|
|
Collaborator
|
Is this stale? It looks like it is needs to be pointed to |
clundin25
force-pushed
the
fix-warm-reset
branch
2 times, most recently
from
c8955e5 to
284ce91
Compare
Collaborator
Author
@zhalvorsen should be cleaned up and ready for review now! |
zhalvorsen
previously approved these changes
Dec 11, 2025
swenson
previously approved these changes
Dec 11, 2025
mhatrevi
previously approved these changes
Dec 11, 2025
clundin25
force-pushed
the
fix-warm-reset
branch
from
284ce91 to
870104f
Compare
zhalvorsen
previously approved these changes
Dec 11, 2025
clundin25
force-pushed
the
fix-warm-reset
branch
from
870104f to
f8f4355
Compare
* Re-enable driver warm reset test. * Add DERIVE_MEK warm reset test.
clundin25
force-pushed
the
fix-warm-reset
branch
from
f8f4355 to
531233f
Compare
clundin25
commented
Dec 11, 2025
Comment on lines
-46
to
+47
| mek_checksum: EXPECTED_MEK_CHECKSUM, | ||
| // mek_checksum: EXPECTED_MEK_CHECKSUM, | ||
| mek_checksum: [0; 16], |
Collaborator
Author
There was a problem hiding this comment.
NOTE: Unless there is feedback I will fix this in the next PR. The CI takes some time to run and this is gating other PRs.
zhalvorsen
approved these changes
Dec 12, 2025
swenson
approved these changes
Dec 12, 2025
mhatrevi
approved these changes
Dec 12, 2025
clundin25
added a commit
to clundin25/caliptra-sw
that referenced
this pull request
Dec 12, 2025
These tests should be fixed by the MCU changes merged in chipsalliance#2878.
meilu-git
pushed a commit
that referenced
this pull request
Jan 6, 2026
* Re-enable driver warm reset test. * Add DERIVE_MEK warm reset test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed a few tweaks after changes to warm reset.