[dpe] Update to non-generic crypto API#3621
Merged
Merged
Conversation
zhalvorsen
force-pushed
the
push-wpmqmpuplnsl
branch
3 times, most recently
from
f3b31c5 to
97c9823
Compare
Having generics in the API was duplicating much of the complicated DPE code (certificate encoding) which bloated the code size unnecessarily. DPE was updated to remove the generics so this gains some codespace back.
zhalvorsen
force-pushed
the
push-wpmqmpuplnsl
branch
from
97c9823 to
6b127e0
Compare
zhalvorsen
requested review from
JohnTraverAmd,
ajisaxena,
bluegate010,
fdamato,
jhand2,
korran,
mhatrevi,
rusty1968,
swenson,
timothytrippel and
vsonims
as code owners
clundin25
reviewed
Apr 21, 2026
clundin25
reviewed
Apr 21, 2026
clundin25
approved these changes
Apr 21, 2026
Collaborator
clundin25
left a comment
clundin25
left a comment
There was a problem hiding this comment.
Nice code space gains !
timothytrippel
approved these changes
Apr 21, 2026
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having generics in the API was duplicating much of the complicated DPE code (certificate encoding) which bloated the code size unnecessarily. DPE was updated to remove the generics so this gains some codespace back.