fix(x509): use ROM and FW versions in cert subjects#3662
Open
ArthurHeymans wants to merge 1 commit into
Open
Conversation
ArthurHeymans
requested review from
ajisaxena,
bluegate010,
fdamato,
jhand2,
jlmahowa-amd,
mhatrevi,
rusty1968,
swenson,
timothytrippel,
vsonims and
zhalvorsen
as code owners
April 27, 2026 15:10
ArthurHeymans
force-pushed
the
IDEV_LDEV_ROM_VERSION
branch
from
April 28, 2026 15:58
c1b8a37 to
6c06e27
Compare
ArthurHeymans
requested review from
JohnTraverAmd,
korran and
nquarton
as code owners
April 28, 2026 15:58
Derive certificate common names from the canonical version constants so IDevID and LDevID identify the ROM version, while FMC and RT aliases identify the mutable firmware version. Regenerate the X.509 templates to match. Fix the DER TBS length calculation for two-byte lengths whose low byte crosses the carry boundary, which the longer subject names expose. Signed-off-by: Arthur Heymans <arthur.heymans@9elements.com>
ArthurHeymans
force-pushed
the
IDEV_LDEV_ROM_VERSION
branch
from
May 15, 2026 14:07
6c06e27 to
f27f5b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derive certificate common names from the canonical version constants so
IDevID and LDevID identify the ROM version, while FMC and RT aliases
identify the mutable firmware version. Regenerate the X.509 templates to
match.
Fix the DER TBS length calculation for two-byte lengths whose low byte
crosses the carry boundary, which the longer subject names expose.
Addresses #2355
Signed-off-by: Arthur Heymans arthur.heymans@9elements.com