Libcaliptra: Adding length check to invoke DPE commands#3865
Closed
nquarton wants to merge 1 commit into
Closed
Conversation
nquarton
requested review from
JohnTraverAmd,
clundin25,
fdamato,
jhand2,
jlmahowa-amd,
korran,
mhatrevi,
swenson,
ternst-nv,
timothytrippel,
vsonims,
wmaroneAMD and
zhalvorsen
as code owners
June 11, 2026 00:02
zhalvorsen
approved these changes
Jun 11, 2026
mhatrevi
approved these changes
Jun 11, 2026
Collaborator
Author
|
I didn't look at this closely enough. The structs here use a variable length data field (data[0]). So this check doesn't work. I don't want to change anything and break current integrators and I can't think of a way to improve this without doing so. So, I think I am going to drop this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.