Record subsystem mode in ROM DeviceStatus measurement#3930
Open
v-focutter wants to merge 12 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the ROM DeviceStatus PCR log measurement to include the current subsystem/passive mode, and keeps the FMC Alias vendor device-info hash and integration tests aligned with the updated measured contents.
Changes:
- Extend the ROM
DeviceStatusmeasured data withsubsystem_mode_en(as au8). - Update
PcrLogEntry::measured_data()sizing forDeviceStatusfrom 17 to 18 bytes. - Update FMC Alias vendor device-info hash inputs and ROM integration tests to validate the new field (including both passive and subsystem-mode cases).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| rom/dev/tests/rom_integration_tests/test_fmcalias_derivation.rs | Updates expected DeviceStatus bytes and adds explicit tests for passive vs subsystem mode. |
| rom/dev/src/pcr.rs | Adds subsystem mode byte to the ROM DeviceStatus PCR extension payload. |
| drivers/src/pcr_log.rs | Updates DeviceStatus measured-data length to 18 bytes. |
| common/src/dice.rs | Includes subsystem mode in the FMC Alias vendor device-info hash inputs. |
| FROZEN_IMAGES.sha384sum | Updates frozen ROM image hashes to reflect the ROM measurement change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+3
| # WARNING: Do not update this file without the approval of the Caliptra TAC | ||
| 178f7a10b43275c68ae4698569b720678eb349c4d1deb3c8e3faf7a27ecce072e52874b186cb96a8a46a3f2b7bc4fb1d caliptra-rom-no-log.bin | ||
| 5ee14fc648c2fec43556f03ec1422d77b28d1981368217fb6853f1d2feaefc59eca38a587db54cb3e1df8b7ca14f6a55 caliptra-rom-with-log.bin | ||
| 5ffc771603fbcba3d8cdb44c37624e2f89da8842a91a5dc78508e76ca235221d77a69adcaf091a51e9223aa2ede3b19a caliptra-rom-no-log.bin | ||
| 035fdf377d1495a61053513ade035c3eb0c376bf6b5ed95298cccde1541f5da9fdf85f98613b8fd9a4f133f156f1c376 caliptra-rom-with-log.bin |
v-focutter
marked this pull request as ready for review
June 30, 2026 15:52
v-focutter
requested review from
JohnTraverAmd,
ajisaxena,
clundin25,
jhand2,
korran,
mhatrevi,
rusty1968,
ternst-nv,
timothytrippel,
vsonims and
zhalvorsen
as code owners
June 30, 2026 15:52
mhatrevi
reviewed
Jul 14, 2026
mhatrevi
left a comment
Collaborator
There was a problem hiding this comment.
@v-focutter Please investigate the CI failure.
…iptra-sw into v-focutter/subsystem-mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summery:
Task 3916