Skip to content

Record subsystem mode in ROM DeviceStatus measurement#3930

Open
v-focutter wants to merge 12 commits into
chipsalliance:mainfrom
v-focutter:v-focutter/subsystem-mode
Open

Record subsystem mode in ROM DeviceStatus measurement#3930
v-focutter wants to merge 12 commits into
chipsalliance:mainfrom
v-focutter:v-focutter/subsystem-mode

Conversation

@v-focutter

Copy link
Copy Markdown
Collaborator

Summery:

  • Added the subsystem to the device status
  • Added Tests for both states of the new flag

Task 3916

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the ROM DeviceStatus PCR log measurement to include the current subsystem/passive mode, and keeps the FMC Alias vendor device-info hash and integration tests aligned with the updated measured contents.

Changes:

  • Extend the ROM DeviceStatus measured data with subsystem_mode_en (as a u8).
  • Update PcrLogEntry::measured_data() sizing for DeviceStatus from 17 to 18 bytes.
  • Update FMC Alias vendor device-info hash inputs and ROM integration tests to validate the new field (including both passive and subsystem-mode cases).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
rom/dev/tests/rom_integration_tests/test_fmcalias_derivation.rs Updates expected DeviceStatus bytes and adds explicit tests for passive vs subsystem mode.
rom/dev/src/pcr.rs Adds subsystem mode byte to the ROM DeviceStatus PCR extension payload.
drivers/src/pcr_log.rs Updates DeviceStatus measured-data length to 18 bytes.
common/src/dice.rs Includes subsystem mode in the FMC Alias vendor device-info hash inputs.
FROZEN_IMAGES.sha384sum Updates frozen ROM image hashes to reflect the ROM measurement change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread drivers/src/pcr_log.rs
Comment thread rom/dev/src/pcr.rs Outdated
Comment thread common/src/dice.rs Outdated
Comment thread FROZEN_IMAGES.sha384sum Outdated
Comment on lines +1 to +3
# WARNING: Do not update this file without the approval of the Caliptra TAC
178f7a10b43275c68ae4698569b720678eb349c4d1deb3c8e3faf7a27ecce072e52874b186cb96a8a46a3f2b7bc4fb1d caliptra-rom-no-log.bin
5ee14fc648c2fec43556f03ec1422d77b28d1981368217fb6853f1d2feaefc59eca38a587db54cb3e1df8b7ca14f6a55 caliptra-rom-with-log.bin
5ffc771603fbcba3d8cdb44c37624e2f89da8842a91a5dc78508e76ca235221d77a69adcaf091a51e9223aa2ede3b19a caliptra-rom-no-log.bin
035fdf377d1495a61053513ade035c3eb0c376bf6b5ed95298cccde1541f5da9fdf85f98613b8fd9a4f133f156f1c376 caliptra-rom-with-log.bin

@mhatrevi mhatrevi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-focutter Please investigate the CI failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants