-
Notifications
You must be signed in to change notification settings - Fork 650
Expand file tree
/
Copy pathDomainSpec.scala
More file actions
592 lines (483 loc) · 17.6 KB
/
DomainSpec.scala
File metadata and controls
592 lines (483 loc) · 17.6 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
// SPDX-License-Identifier: Apache-2.0
package chiselTests
import chisel3._
import chisel3.domain.{Domain, Field}
import chisel3.domains.ClockDomain
import chisel3.experimental.dataview._
import chisel3.properties.Property
import chisel3.testing.{FileCheck, HasTestingDirectory}
import chisel3.testing.scalatest.TestingDirectory
import chisel3.util.experimental.InlineInstance
import circt.stage.ChiselStage
import java.io.ByteArrayOutputStream
import java.nio.file.Files
import org.scalatest.flatspec.AnyFlatSpec
import org.scalatest.matchers.should.Matchers
import scala.annotation.nowarn
import scala.sys.process._
class DomainSpec extends AnyFlatSpec with Matchers with FileCheck with TestingDirectory {
behavior of "Domains"
they should "emit FIRRTL for internal and user-defined domains" in {
object PowerDomain extends Domain {
override def fields = Seq(
("name", Field.String),
("voltage", Field.Integer),
("alwaysOn", Field.Boolean)
)
}
class Foo extends RawModule {
val A = IO(Input(ClockDomain.Type()))
val B = IO(Input(PowerDomain.Type()))
val a = IO(Input(Bool()))
val b = IO(Output(Bool()))
associate(a, A)
associate(b, B)
b :<= domain.unsafeCast(a, B)
}
ChiselStage.emitCHIRRTL(new Foo).fileCheck() {
"""|CHECK: circuit Foo :
|CHECK: domain ClockDomain :
|CHECK-NEXT: name : String
|CHECK-NEXT: source : String
|CHECK-NEXT: relationship : String
|
|CHECK: domain PowerDomain :
|CHECK-NEXT: name : String
|CHECK-NEXT: voltage : Integer
|CHECK-NEXT: alwaysOn : Bool
|
|CHECK: public module Foo :
|CHECK-NEXT: input A : Domain of ClockDomain
|CHECK-NEXT: input B : Domain of PowerDomain
|CHECK-NEXT: input a : UInt<1> domains [A]
|CHECK-NEXT: output b : UInt<1> domains [B]
|
|CHECK: node [[cast:.*]] = unsafe_domain_cast(a, B)
|CHECK-NEXT: connect b, [[cast]]
|""".stripMargin
}
}
they should "fail to work with blackboxes" in {
@nowarn("cat=deprecation")
class Bar extends BlackBox {
val io = IO {
new Bundle {
val A = Input(ClockDomain.Type())
val a = Input(UInt(1.W))
}
}
associate(io.a, io.A)
}
class Foo extends Module {
private val bar = Module(new Bar)
}
intercept[ChiselException] {
ChiselStage.elaborate(new Foo, Array("--throw-on-first-error"))
}.getMessage should include("Unable to associate data")
}
they should "work for extmodules" in {
class Bar extends ExtModule {
val A = IO(Input(ClockDomain.Type()))
val a = IO(Input(UInt(1.W)))
associate(a, A)
}
class Foo extends RawModule {
private val bar = Module(new Bar)
}
ChiselStage.emitCHIRRTL(new Foo).fileCheck() {
"""|CHECK: extmodule Bar :
|CHECK-NEXT: input A : Domain of ClockDomain
|CHECK-NEXT: input a : UInt<1> domains [A]
|""".stripMargin
}
}
they should "be capable of being forwarded with the domain define operation" in {
class Foo extends RawModule {
val a = IO(Input(ClockDomain.Type()))
val b = IO(Output(ClockDomain.Type()))
domain.define(b, a)
}
ChiselStage.emitCHIRRTL(new Foo).fileCheck() {
"""|CHECK: module Foo :
|CHECK: domain_define b = a
|""".stripMargin
}
}
behavior of "The associate method"
it should "error if given zero arguments" in {
class Foo extends RawModule {
val a = IO(Input(Bool()))
associate(a)
}
intercept[IllegalArgumentException] {
ChiselStage.elaborate(new Foo)
}.getMessage should include("cannot associate a port or wire with zero domains")
}
it should "work on views" in {
class Foo extends RawModule {
val A = IO(Input(ClockDomain.Type()))
val a = IO(Input(Bool()))
associate(a.viewAs[Bool], A)
}
ChiselStage.emitCHIRRTL(new Foo).fileCheck() {
"""|CHECK: module Foo :
|CHECK: input a : UInt<1> domains [A]
|""".stripMargin
}
}
it should "work with FlatIO" in {
class Foo extends RawModule {
val A = IO(Input(ClockDomain.Type()))
val io = FlatIO(new Bundle {
val a = Input(Bool())
})
associate(io.a, A)
}
ChiselStage.emitCHIRRTL(new Foo).fileCheck() {
"""|CHECK: module Foo :
|CHECK: input a : UInt<1> domains [A]
|""".stripMargin
}
}
it should "allow for multiple ports" in {
class Foo extends RawModule {
val A = IO(Input(ClockDomain.Type()))
val a, b = IO(Input(Bool()))
associate(Seq(a, b), A)
}
ChiselStage.emitCHIRRTL(new Foo).fileCheck() {
"""|CHECK: input a : UInt<1> domains [A]
|CHECK: input b : UInt<1> domains [A]
|""".stripMargin
}
}
behavior of "unsafe_domain_cast"
it should "work for zero, one, and two casts" in {
object DomainA extends Domain
object DomainB extends Domain
class Foo extends RawModule {
val A = IO(Input(DomainA.Type()))
val B = IO(Input(DomainB.Type()))
val in = IO(Input(Bool()))
val out = IO(Output(Bool()))
out :<= domain.unsafeCast(in)
out :<= domain.unsafeCast(in, A)
out :<= domain.unsafeCast(in, B)
out :<= domain.unsafeCast(in, A, B)
}
ChiselStage.emitCHIRRTL(new Foo).fileCheck() {
"""|CHECK: unsafe_domain_cast(in)
|CHECK: unsafe_domain_cast(in, A)
|CHECK: unsafe_domain_cast(in, B)
|CHECK: unsafe_domain_cast(in, A, B)
|""".stripMargin
}
}
behavior of "domain subfield access"
it should "allow accessing fields of a domain port" in {
class Foo extends RawModule {
val A = IO(Input(ClockDomain.Type()))
val nameOut = IO(Output(Property[String]()))
val sourceOut = IO(Output(Property[String]()))
nameOut := A.field.name
sourceOut := A.field.source
}
ChiselStage.emitCHIRRTL(new Foo).fileCheck() {
"""|CHECK: module Foo :
|CHECK: input A : Domain of ClockDomain
|CHECK: output nameOut : String
|CHECK: output sourceOut : String
|CHECK: propassign nameOut, A.name
|CHECK: propassign sourceOut, A.source
|""".stripMargin
}
}
behavior of "domain instantiation"
it should "allow instantiating a synchronous domain" in {
class Foo extends RawModule {
val A = IO(Input(ClockDomain.Type()))
val B = IO(Output(ClockDomain.Type()))
val b = ClockDomain.synchronous(A, "_1to4")
domain.define(B, b)
}
ChiselStage.emitCHIRRTL(new Foo).fileCheck() {
"""|CHECK: module Foo :
|CHECK: input A : Domain of ClockDomain
|CHECK: output B : Domain of ClockDomain
|CHECK: wire [[name:.+]] : String
|CHECK: propassign [[name]], string_concat(A.name, String("_1to4"))
|CHECK: domain [[b:.*]] of ClockDomain([[name]], A.name, String("synchronous"))
|CHECK: domain_define B = [[b]]
|""".stripMargin
}
}
it should "allow instantiating a rational domain" in {
class Foo extends RawModule {
val A = IO(Input(ClockDomain.Type()))
val B = IO(Output(ClockDomain.Type()))
val b = ClockDomain.rational(A, "_2to3")
domain.define(B, b)
}
ChiselStage.emitCHIRRTL(new Foo).fileCheck() {
"""|CHECK: module Foo :
|CHECK: input A : Domain of ClockDomain
|CHECK: output B : Domain of ClockDomain
|CHECK: wire [[name:.+]] : String
|CHECK: propassign [[name]], string_concat(A.name, String("_2to3"))
|CHECK: domain [[b:.*]] of ClockDomain([[name]], A.name, String("rational"))
|CHECK: domain_define B = [[b]]
|""".stripMargin
}
}
it should "error when property type doesn't match field type" in {
object TestDomain extends Domain {
override def fields = Seq(
("name", Field.String),
("value", Field.Integer),
("flag", Field.Boolean)
)
def apply(): chisel3.domain.Type = TestDomain(Property("test"), Property("wrong"), Property(true))
}
class WrongTypeModule extends RawModule {
// Wrong type for second field: String instead of Integer
val bad = TestDomain()
}
val exception = intercept[ChiselException] {
ChiselStage.elaborate(new WrongTypeModule, Array("--throw-on-first-error"))
}
exception.getMessage should include("field 'value' expects Property[Int] but got Property[String]")
}
it should "error when property count doesn't match field count" in {
object TestDomain extends Domain {
override def fields = Seq(
("name", Field.String),
("value", Field.Integer),
("flag", Field.Boolean)
)
def apply(): chisel3.domain.Type = TestDomain(Property("test"))
}
class WrongCountModule extends RawModule {
// Only one property when three are expected
val bad = TestDomain()
}
val exception = intercept[ChiselException] {
ChiselStage.elaborate(new WrongCountModule, Array("--throw-on-first-error"))
}
exception.getMessage should include("requires 3 properties but got 1")
}
behavior of "Wire domain associations"
it should "allow associating a wire with a domain" in {
class Foo extends RawModule {
val A = IO(Input(ClockDomain.Type()))
val w = Wire(UInt(8.W))
associate(w, A)
}
ChiselStage.emitCHIRRTL(new Foo).fileCheck() {
"""|CHECK: module Foo :
|CHECK: input A : Domain of ClockDomain
|CHECK: wire w : UInt<8> domains [A]
|""".stripMargin
}
}
it should "allow associating a wire with multiple domains" in {
object PowerDomain extends Domain {
override def fields = Seq(
("name", Field.String),
("voltage", Field.Integer)
)
}
class Foo extends RawModule {
val A = IO(Input(ClockDomain.Type()))
val B = IO(Input(PowerDomain.Type()))
val w = Wire(UInt(16.W))
associate(w, A, B)
}
ChiselStage.emitCHIRRTL(new Foo).fileCheck() {
"""|CHECK: module Foo :
|CHECK: wire w : UInt<16> domains [A, B]
|""".stripMargin
}
}
it should "error if associating a wire from another module" in {
class Bar extends RawModule {
val A = IO(Input(ClockDomain.Type()))
val w = Wire(UInt(8.W))
}
class Foo extends RawModule {
val bar = Module(new Bar)
val A = IO(Input(ClockDomain.Type()))
// Try to associate a wire from another module
associate(bar.w, A)
}
intercept[ChiselException] {
ChiselStage.elaborate(new Foo, Array("--throw-on-first-error"))
}.getMessage should include("Unable to associate")
}
it should "work with multiple wires" in {
class Foo extends RawModule {
val A = IO(Input(ClockDomain.Type()))
val w1 = Wire(UInt(8.W))
val w2 = Wire(UInt(8.W))
associate(Seq(w1, w2), A)
}
ChiselStage.emitCHIRRTL(new Foo).fileCheck() {
"""|CHECK: wire w1 : UInt<8> domains [A]
|CHECK: wire w2 : UInt<8> domains [A]
|""".stripMargin
}
}
it should "error if given zero domains" in {
class Foo extends RawModule {
val w = Wire(UInt(8.W))
associate(w)
}
intercept[IllegalArgumentException] {
ChiselStage.elaborate(new Foo)
}.getMessage should include("cannot associate a port or wire with zero domains")
}
behavior of ("Domain assertions")
trait Domains {
def A: domain.Type
def B: domain.Type
}
object Domains {
/** Return two asynchronous (unrelated) domains. */
def asynchronous() = new Domains {
override val A = ClockDomain("A")
override val B = ClockDomain("B")
}
/** Return two domains, the second of which is synchronous to the first */
def synchronous() = new Domains {
override val A = ClockDomain("A")
override val B = ClockDomain.synchronous(A, "_1to2")
}
/** Return two domains, the second of which is rationally related to the first. */
def rational() = new Domains {
override val A = ClockDomain("A")
override val B = ClockDomain.rational(A, "_2to3")
}
}
abstract class Crossing extends RawModule {
val A, B = IO(Input(ClockDomain.Type()))
}
object Crossing {
/** Cross between any two domains. */
class Asynchronous extends Crossing
/** Cross between synchronous domains. */
class Synchronous extends Crossing {
(A.field.source.asInstanceOf[Property[String]] === B.field.source.asInstanceOf[Property[String]])
.assert(s"clock domains 'A' and 'B' must have the same source")
(A.field.relationship.asInstanceOf[Property[String]] === ClockDomain.Relationship.Synchronous.toProperty())
.assert(s"clock domain 'A' must have a synchronous relationship")
(B.field.relationship.asInstanceOf[Property[String]] === ClockDomain.Relationship.Synchronous.toProperty())
.assert(s"clock domain 'B' must have a synchronous relationship")
}
/** Cross between synchronous or rational domains.
*
* @note This needs to be updated once boolean or is a supported property
* expression.
*/
class Rational extends Crossing {
(A.field.source.asInstanceOf[Property[String]] === B.field.source.asInstanceOf[Property[String]])
.assert(s"clock domains 'A' and 'B' must have the same source")
(A.field.relationship.asInstanceOf[Property[String]] === ClockDomain.Relationship.Synchronous.toProperty())
.assert(s"clock domain 'A' must have a rational relationship")
(B.field.relationship.asInstanceOf[Property[String]] === ClockDomain.Relationship.Rational.toProperty())
.assert(s"clock domain 'B' must have a rational relationship")
}
}
class CrossingTestHarness(
crossingGen: () => Crossing,
domainsGen: () => Domains
) extends RawModule {
private val crossing = Module(crossingGen())
private val domains = domainsGen()
domain.define(crossing.A, domains.A)
domain.define(crossing.B, domains.B)
}
case class CrossingTest(name: String, genHarness: () => CrossingTestHarness, result: Either[String, Unit]) {
private val description = {
(result match {
case Right(_) => "pass"
case Left(_) => "error"
}) ++ s" for $name"
}
def test() = they should description in {
val dir = implicitly[HasTestingDirectory].getDirectory
Files.createDirectories(dir)
val finalMlir = dir.resolve("final.mlir").toString
ChiselStage.emitSystemVerilog(
genHarness(),
firtoolOpts = Array("-domain-mode=infer-all", "-output-final-mlir", finalMlir)
)
val stderrStream = new ByteArrayOutputStream
val logger = ProcessLogger(_ => (), line => { stderrStream.write(line.getBytes); stderrStream.write('\n') })
try {
val exitCode: Int = Seq("domaintool", "--module", "CrossingTestHarness", finalMlir).!(logger)
result match {
case Right(_) =>
exitCode should be(0)
case Left(error) =>
exitCode should not be (0)
stderrStream.toString should include(error)
}
} catch {
case a: java.io.IOException if a.getMessage().startsWith("Cannot run program") =>
info("skipped as 'domaintool' is not available")
}
}
}
Seq(
// ---------------------------------- Synchronous crossing
CrossingTest(
"a synchronous crossing with synchronous clocks",
() => new CrossingTestHarness(() => new Crossing.Synchronous, Domains.synchronous),
Right(())
),
CrossingTest(
"a synchronous crossing with rational clocks",
() => new CrossingTestHarness(() => new Crossing.Synchronous, Domains.rational),
Left("clock domain 'B' must have a synchronous relationship")
),
CrossingTest(
"a synchronous crossing with asynchronous clocks",
() => new CrossingTestHarness(() => new Crossing.Synchronous, Domains.asynchronous),
Left("clock domains 'A' and 'B' must have the same source")
),
// ---------------------------------- Rational crossing
// TODO: This currently fails as we need a property boolean or to express
// that a rational crossing can handle both synchronous and rational
// relationships.
// CrossingTest(
// "a rationl crossing with synchronous clocks",
// () => new CrossingTestHarness(() => new Crossing.Rational, Domains.synchronous),
// Right(())
// ),
CrossingTest(
"a rationl crossing with rational clocks",
() => new CrossingTestHarness(() => new Crossing.Rational, Domains.rational),
Right(())
),
CrossingTest(
"a rational crossing with asynchronous clocks",
() => new CrossingTestHarness(() => new Crossing.Rational, Domains.asynchronous),
Left("clock domains 'A' and 'B' must have the same source")
),
// ---------------------------------- Asynchronous crossing
CrossingTest(
"an aasynchronous crossing with synchronous clocks",
() => new CrossingTestHarness(() => new Crossing.Asynchronous, Domains.synchronous),
Right(())
),
CrossingTest(
"an asynchronous crossing with rational clocks",
() => new CrossingTestHarness(() => new Crossing.Asynchronous, Domains.rational),
Right(())
),
CrossingTest(
"an asynchronous crossing with asynchronous clocks",
() => new CrossingTestHarness(() => new Crossing.Asynchronous, Domains.asynchronous),
Right(())
)
).foreach { _.test() }
}