run: fix disabling the c extension
#988
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkokosinski
force-pushed
the
61959-add-bitmanip-dv
branch
from
e560506 to
a6b8ce2
Compare
This commit fixes the way that the `c` extension is disabled, i.e. removed from the arch ISA string. Without this change, for GCC versions where Zicsr and Zifencei constitute separate extensions, the following ISA string: rv32imc_zicsr_zifencei_zba_zbb_zbc_zbs Would be changed to (note incorrect `_zisr` vs correct `_zicsr`): rv32im_zisr_zifenei_zba_zbb_zb_zbs Instead of the expected: rv32im_zicsr_zifencei_zba_zbb_zbc_zbs Signed-off-by: Filip Kokosinski <[email protected]>
fkokosinski
force-pushed
the
61959-add-bitmanip-dv
branch
from
df1dedb to
ec43dcf
Compare
Signed-off-by: Filip Kokosinski <[email protected]>
fkokosinski
force-pushed
the
61959-add-bitmanip-dv
branch
from
ec43dcf to
58bc006
Compare
Collaborator
|
The changes have been approved and merged with #1001. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the way that the
cextension is disabled, i.e. removed from the arch ISA string. Without this change, for GCC versions where Zicsr and Zifencei constitute separate extensions, the following ISA string:Would be changed to (note incorrect
_zisrvs correct_zicsr):Instead of the expected: