.github/bin/run-format.sh is the project style check (clang-format on *.h/*.cc, plus buildifier on BUILD files). Running it on current master rewrites files that were not part of any local change, for example:
verible/common/formatting/align.ccverible/common/formatting/align_test.ccverible/common/text/parser-verifier.hverible/verilog/analysis/flow-tree.hverible/verilog/analysis/verilog-filelist.hverible/verilog/preprocessor/verilog-preprocess.hverible/verilog/tools/kythe/kythe-facts.ccverible/verilog/analysis/checkers/forbid-consecutive-null-statements-rule_test.cc
The whole tree is expected to already match run-format.sh. Drift makes formatter PRs pick up unrelated diffs and makes CI style failures surprising.
Suggested direction
Run .github/bin/run-format.sh on master and land a one-time format-only PR so the tree is clean. After that, CI should be the only source of format changes.
.github/bin/run-format.shis the project style check (clang-format on*.h/*.cc, plus buildifier on BUILD files). Running it on currentmasterrewrites files that were not part of any local change, for example:verible/common/formatting/align.ccverible/common/formatting/align_test.ccverible/common/text/parser-verifier.hverible/verilog/analysis/flow-tree.hverible/verilog/analysis/verilog-filelist.hverible/verilog/preprocessor/verilog-preprocess.hverible/verilog/tools/kythe/kythe-facts.ccverible/verilog/analysis/checkers/forbid-consecutive-null-statements-rule_test.ccThe whole tree is expected to already match
run-format.sh. Drift makes formatter PRs pick up unrelated diffs and makes CI style failures surprising.Suggested direction
Run
.github/bin/run-format.shonmasterand land a one-time format-only PR so the tree is clean. After that, CI should be the only source of format changes.