Skip to content

Dish array merge main - #1

Open
Arnab-half-blood-prince wants to merge 25 commits into
dish_array_mergefrom
dish_array_merge_main
Open

Dish array merge main#1
Arnab-half-blood-prince wants to merge 25 commits into
dish_array_mergefrom
dish_array_merge_main

Conversation

@Arnab-half-blood-prince

Copy link
Copy Markdown

This branch is updated with the latest changes in caput, cora.

I also merged ss/anspos-ext to this branch, as that gives an accurate telescope sim for different declinations.

@mwilensky768

Copy link
Copy Markdown

@Arnab-half-blood-prince have you checked that simulations at different pointing elevations come out OK after merging the new changes?

@Arnab-half-blood-prince

Copy link
Copy Markdown
Author

Yes. So far, I checked CAS-A. It seems to be at the right position and with right flux value in Jy.
image
image

@Arnab-half-blood-prince

Copy link
Copy Markdown
Author

TAU-A and CYG-A are next to check.

@mwilensky768

Copy link
Copy Markdown

OK, great. I think if it looks good we can probably merge it but I'm totally unfamiliar with the changes in the commit history pre-November 2025.

@Arnab-half-blood-prince

Copy link
Copy Markdown
Author

Yes, I think the bulk of changes are made by Liam at the main branch, where many changes happened within caput, cora etc.
The sim looks okay to me. The main branch is working well on the CHIME data, too. I think I will wait a little bit more to see the other source simulation and if Seth and Simon have any comments. It is not too urgent, but we have this branch which tracks the latest development in the main branch.

@Arnab-half-blood-prince

Copy link
Copy Markdown
Author

These are CYG-A and TAU-A. I think the simulation is working.

image image image image

@sjforeman

Copy link
Copy Markdown

@Arnab-half-blood-prince Thanks for carrying out this important work. I trust your tests above that show that these changes are fine. As we've discussed elsewhere, it would be great to eventually merge the disharray code into the upstream driftscan repo, and then delete this fork and have everyone branch from that upstream repo in future. When that happens, I'd be happy to review that PR in detail. It would make sense to coordinate that with Devin as well.

Fix exception message formatting for polarization check.
- Rename drift/telescope/custom_disharray/ to drift/telescope/disharray/,
  replacing the old simple disharray.py module
- Rename CustomDishArray mixin to DishArrayMixin throughout
- Preserve old DishArray class in disharray/core.py for backward compatibility
- Remove HIRAX-specific code (hirax.py, hextile data file, manager.py entries)
  per instrument-agnostic policy; HIRAX implementation belongs in a
  dedicated instrument repo
beam_circular computed 2*jinc(x) = J0(x)+J2(x) = 2*J1(x)/x, which is
identical to airy_beam in beams.py. Remove the redundant _jinc and
beam_circular helpers and call airy_beam/pointing_offset_separation
directly, also dropping the now-unused jn and spherical imports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants