Replace Rokit with Mise

[christopher-buss]

Summary by CodeRabbit

• Documentation

  • Added commit message guidelines and surfaced them to editor tooling; updated README tooling list to use Mise.

• CI

  • Consolidated environment/tool setup under a single action and switched to Corepack-managed pnpm for install/build steps across workflows.

• Chores

  • Added Mise tooling/configuration and example env template; updated package manager pinning, dependency hoisting, workspace tooling, editor settings, git hooks, ignore rules, and Renovate configuration.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Consolidates tooling and workflows around Mise and Corepack. Replaces multi-step Node/pnpm/Rokit setup with jdx/mise-action across CI/release pipelines, updates Husky hooks to use Corepack, adjusts package manager pinning and hoisting, adds Mise toolchain config and VS Code settings, adds commit guidelines, and updates ignore rules.

Changes

Cohort / File(s)	Summary
Workflows: CI & Release .github/workflows/ci.yaml, .github/workflows/release-development.yaml, .github/workflows/release.yaml	Replace explicit Node/pnpm/Rokit setup with jdx/mise-action@5ac50f7…. Remove node-version matrix from CI. Use Corepack-wrapped pnpm commands (corepack pnpm ...) for install/add/build. Update compile invocation(s) (e.g., npx rbxtsc → nlx rbxtsc). Apply Mise action in deploy jobs.
Husky hooks .husky/commit-msg, .husky/post-merge, .husky/pre-commit	Swap direct pnpm calls for Corepack-wrapped invocations: corepack pnpm dlx commitlint --edit "$1", corepack pnpm install, and corepack pnpm lint-staged.
Mise & Tooling manifests mise.toml, rokit.toml	Add Mise env/tools configuration (node lts with postinstall corepack enable, mantle/asphalt/lune/rojo/darklua tools). Remove tool manifest contents from rokit.toml (file cleared).
Package / workspace / npm config package.json, pnpm-workspace.yaml, .npmrc	Add devDependency @antfu/ni and update packageManager to pnpm@10.15.1+sha512… in package.json. Modify pnpm-workspace.yaml catalogs and restructure publicHoistPattern placements (move *@rbxts* under patchedDependencies; hoist unrs-resolver), and reorder ESLint catalog entry. Add .npmrc entry public-hoist-pattern[]=*@rbxts*.
Editor / IDE settings .vscode/settings.json	Add Mise Tools settings: debug.javascript.defaultRuntimeExecutable pointing to .vscode\mise-tools\node and github.copilot.chat.commitMessageGeneration.instructions referencing .github/commit-instructions.md.
Documentation / commit guidance .github/commit-instructions.md, README.md	Add commit message template/guidelines file. Update README: add Mise entry, remove Rokit from Roblox Tools list.
Ignore rules & examples .gitignore, .env.example	Stop ignoring bundled ESLint config and *.mjs; remove .env ignore; add .vscode/mise-tools/ to ignores. Add .env.example with export ASPHALT_API_KEY=.
Renovate config renovate.json	Remove external Renovate config extend (github>christopher-buss/rokit-renovate-config) from extends.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Dev as Developer
  participant GH as GitHub Actions
  participant Mise as jdx/mise-action
  participant Corepack as Corepack (pnpm)
  participant Build as Build Steps

  Dev->>GH: Push / PR / Tag
  GH->>Mise: Setup toolchain (Node LTS, enable Corepack)
  Mise-->>GH: Toolchain ready
  GH->>Corepack: corepack pnpm install
  Corepack-->>GH: deps installed
  GH->>Build: Run compile/build (nlx rbxtsc / corepack pnpm prod:build)
  Build-->>GH: artifacts / results
  Note over GH,Build: Lint and other steps run via Corepack-wrapped pnpm

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Poem

I thump my paw, the pipelines sing,
Mise brings tools upon a string.
Corepack hops where pnpm goes,
Hooks and builds in tidy rows.
Commitlines bloom — the repo grows. 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c7d4090 and 061057f.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (8)

• .env.example (1 hunks)
• .github/workflows/release.yaml (2 hunks)
• .husky/commit-msg (1 hunks)
• mise.toml (1 hunks)
• package.json (2 hunks)
• pnpm-workspace.yaml (3 hunks)
• renovate.json (0 hunks)
• rokit.toml (0 hunks)

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/mise

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 6

🧹 Nitpick comments (15)

README.md (1)

47-53: Document the Mise workflow in “How to use”.

Without telling newcomers to run “mise install”, pnpm/rojo/etc. may be missing. Suggest adding a Mise step.

Apply:

 1. Press the green `Use this template` button on the top right of the page to
    create a new repository.
 2. Clone the repository to your local machine.
-3. Run `pnpm install` to install all the dependencies.
-4. Run `pnpm run dev:start` to start the development server.
-5. Start coding! 🎉
+3. Install Mise and run `mise install` to install Node/pnpm and Roblox CLI tools.
+4. Run `pnpm install` to install all the dependencies.
+5. Run `pnpm run dev:start` to start the development server.
+6. Start coding! 🎉

.npmrc (1)

5-6: Be cautious with peer deps and global hoisting.

• strict-peer-dependencies=false can hide real integration issues; consider keeping it true in CI and relaxing locally if needed.
• public-hoist-pattern[]=*@rbxts* is fine, but do confirm it doesn’t cause duplicate versions of non-rbxts libs to leak into the public tree.

If desired, I can script a quick “pnpm why” audit across rbxts packages to surface duplicates. Want that?

.husky/post-merge (1)

5-5: Run hooks inside Mise and avoid npx.

Ensure Node/pnpm availability and pin dlx tool. Also fix the stale comment above (it mentions package-lock but you match pnpm-lock).

Apply:

-# matches only the package-lock.json inside project directory
-npx git-pull-run --pattern "pnpm-lock.yaml" --command "corepack pnpm install"
+# matches only the pnpm-lock.yaml inside project directory
+mise x -- corepack pnpm dlx git-pull-run --pattern "pnpm-lock.yaml" --command "corepack pnpm install"

.husky/pre-commit (1)

1-1: Ensure hook uses the Mise toolchain.

Wrap with mise x -- so devs without a global Node still pass hooks.

-corepack pnpm lint-staged
+mise x -- corepack pnpm lint-staged

.github/workflows/ci.yaml (1)

25-25: Mise action pin looks solid; consider freezing pnpm in CI.

Since Corepack is enabled via Mise, prefer explicit Corepack usage with a frozen lockfile to fail on drift.

-      - name: Install dependencies
-        run: pnpm install
+      - name: Install dependencies
+        run: corepack pnpm install --frozen-lockfile

Optional: tighten permissions for PRs (read-only) unless a job actually needs write.

I can propose a split-permissions snippet (PR vs. push) if you want.

pnpm-workspace.yaml (2)

56-56: Confirm onlyBuiltDependencies needs unrs-resolver.

onlyBuiltDependencies limits native builds to this list. Please confirm unrs-resolver actually ships native code that must be built in CI; if not, drop it to speed installs.

---

62-63: Avoid duplicating hoist config across files.

You now set publicHoistPattern here; if .npmrc also sets public-hoist-pattern, choose one source of truth (prefer pnpm-workspace.yaml) to prevent drift.

.github/workflows/release.yaml (4)

32-32: Add mise options for Corepack/caching.

Provide Corepack and cache via inputs to reduce setup churn.

Apply this diff:

-      - uses: jdx/mise-action@5ac50f778e26fac95da98d50503682459e86d566 # v3.2
+      - uses: jdx/mise-action@5ac50f778e26fac95da98d50503682459e86d566 # v3.2
+        with:
+          corepack: true
+          cache: true

---

44-44: Minor: keep script runner consistent.

prod:build internally uses npm/npx. Prefer pnpm exec/bins to avoid pulling globals. Consider refactoring the package.json script to use pnpm exec rbxtsc and pnpm run darklua.

---

64-64: Mirror mise options in deploy job.

Same optimization as build: enable Corepack and caching.

Apply this diff:

-      - uses: jdx/mise-action@5ac50f778e26fac95da98d50503682459e86d566 # v3.2
+      - uses: jdx/mise-action@5ac50f778e26fac95da98d50503682459e86d566 # v3.2
+        with:
+          corepack: true
+          cache: true

---

83-101: Optional: harden IP polling.

httpbin can return multiple IPs (comma-separated). Consider contains-match and a longer timeout to reduce flakes.

.github/workflows/release-development.yaml (2)

29-29: Add mise options for Corepack/caching (dev build).

Same rationale as release workflow.

Apply this diff:

-      - uses: jdx/mise-action@5ac50f778e26fac95da98d50503682459e86d566 # v3.2
+      - uses: jdx/mise-action@5ac50f778e26fac95da98d50503682459e86d566 # v3.2
+        with:
+          corepack: true
+          cache: true

---

61-61: Mirror mise options in deploy job (dev).

Enable Corepack and caching here too.

Apply this diff:

-      - uses: jdx/mise-action@5ac50f778e26fac95da98d50503682459e86d566 # v3.2
+      - uses: jdx/mise-action@5ac50f778e26fac95da98d50503682459e86d566 # v3.2
+        with:
+          corepack: true
+          cache: true

.github/commit-instructions.md (1)

33-33: Fix typo in rules.

“capitilization” → “capitalization”.

Apply this diff:

-# * No capitilization in the subject aside from issue references
+# * No capitalization in the subject aside from issue references

.vscode/settings.json (1)

31-34: Make the Node runtime path cross-platform.

Backslashes limit this to Windows. Use forward slashes so it works on all OSes, or commit OS-specific settings separately.

Apply this diff:

-  "debug.javascript.defaultRuntimeExecutable": {
-    "pwa-node": "${workspaceFolder}\\.vscode\\mise-tools\\node"
-  },
+  "debug.javascript.defaultRuntimeExecutable": {
+    "pwa-node": "${workspaceFolder}/.vscode/mise-tools/node"
+  },

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cbbc918 and c7d4090.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (14)

• .github/commit-instructions.md (1 hunks)
• .github/workflows/ci.yaml (1 hunks)
• .github/workflows/release-development.yaml (2 hunks)
• .github/workflows/release.yaml (2 hunks)
• .gitignore (1 hunks)
• .husky/commit-msg (1 hunks)
• .husky/post-merge (1 hunks)
• .husky/pre-commit (1 hunks)
• .npmrc (1 hunks)
• .vscode/settings.json (1 hunks)
• README.md (1 hunks)
• mise.toml (1 hunks)
• package.json (1 hunks)
• pnpm-workspace.yaml (2 hunks)

🔇 Additional comments (8)

README.md (1)

76-76: Mise entry looks good and aligns with PR intent.

Nice swap-in; link and alphabetical placement are correct.

.gitignore (1)

16-18: Good call ignoring Mise’s VS Code artifacts and .env.

Prevents committing local tool shims and secrets.

mise.toml (2)

1-3: Path export is correct.

Ensures local node bins are on PATH when running via Mise.

---

5-10: Pin Node and use stable Mantle

• node = { version = "lts" } can silently upgrade; pin to an explicit LTS (e.g. 20.15.1) for deterministic CI/dev
• mantle = "0.11.17-prerelease" is a prerelease; if a non-prerelease (e.g. 0.11.17 or later) exists, pin to it

-node = { version = "lts", postinstall = "corepack enable" }
+node = { version = "20.15.1", postinstall = "corepack enable" }

Please verify available stable Mantle tag and update accordingly.

package.json (1)

85-85: Corepack pin looks good; ensure runners honor it.

Nice move to a fully pinned pnpm with integrity. In CI, make sure Corepack is enabled by the tool installer (mise). If not, add corepack: true to the mise action or run corepack enable before install to avoid picking a different pnpm.

pnpm-workspace.yaml (1)

12-13: Reordering eslint is harmless.

No functional impact; fine to keep.

.vscode/settings.json (2)

29-29: pnpm workspace default: good.

Helps keep editor commands aligned with Corepack/pnpm.

---

36-40: Nice: Copilot commit guidance wired to the doc.

Good integration to keep messages consistent with your conventions.

[coderabbitai]

⚠️ Potential issue

Remove Rokit step here as well.

To fully deprecate Rokit in development releases.

Apply this diff:

-      - name: Setup Rokit
-        uses: CompeyDev/setup-rokit@d49be92bd9502180218c3f43e7988faa945217b0 # v0.1.2

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	- name: Setup Rokit
	uses: CompeyDev/setup-rokit@d49be92bd9502180218c3f43e7988faa945217b0 # v0.1.2

🤖 Prompt for AI Agents

.github/workflows/release-development.yaml around lines 37 to 39: remove the
"Setup Rokit" job step (the uses: CompeyDev/setup-rokit@... line and its name)
from the workflow so Rokit is no longer invoked for development releases; ensure
you also remove any related step-level keys (name, uses) and fix surrounding
indentation/sequence so the remaining steps form a valid steps list.

[coderabbitai]

🛠️ Refactor suggestion

Use pnpm exec instead of nlx.

nlx may not be present on the runner; pnpm exec is guaranteed after install.

Apply this diff:

-      - name: Compile
-        run: nlx rbxtsc --verbose
+      - name: Compile
+        run: corepack pnpm exec rbxtsc --verbose

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	run: nlx rbxtsc --verbose
	- name: Compile
	run: corepack pnpm exec rbxtsc --verbose

🤖 Prompt for AI Agents

.github/workflows/release-development.yaml around line 41: the workflow uses
"nlx rbxtsc --verbose" which may not exist on the runner; replace the nlx
invocation with "pnpm exec rbxtsc --verbose" so the command runs via pnpm's
guaranteed exec shim after dependencies are installed.

[coderabbitai]

🛠️ Refactor suggestion

Prefer reproducible installs and avoid mutating deps.

• Use --frozen-lockfile to enforce the committed lock.
• Installing roblox-ts during CI is unnecessary if it’s already a devDependency; it also mutates lockfiles if saved.

Apply this diff:

       - name: Install dependencies
-        run: corepack pnpm install
+        run: corepack pnpm install --frozen-lockfile

-      - name: Install roblox-ts
-        run: corepack pnpm add roblox-ts
+      # roblox-ts should already be in devDependencies; no need to add here

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	run: corepack pnpm install
	- name: Install roblox-ts
	run: pnpm add roblox-ts
	run: corepack pnpm add roblox-ts
	- name: Install dependencies
	run: corepack pnpm install --frozen-lockfile
	# roblox-ts should already be in devDependencies; no need to add here

🤖 Prompt for AI Agents

In .github/workflows/release.yaml around lines 35 to 39, replace the loose
install steps so CI uses the committed lockfile and doesn't mutate deps: change
the install command to run "corepack pnpm install --frozen-lockfile" and remove
the separate "corepack pnpm add roblox-ts" step (rely on roblox-ts being a
devDependency in package.json/lockfile); this enforces reproducible installs and
prevents modifying the lockfile during CI.

[howmanysmall]

🥀