Skip to content

[BLD] Do not trigger deploy on merge to release branches #4561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 17, 2025
+4 −3
Merged

[BLD] Do not trigger deploy on merge to release branches #4561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
53d6ad1
[BLD] Do not trigger deploy on merge to release branches
eculver May 16, 2025
4c706b7
use 'control,data' for consistency
eculver May 16, 2025
69aa400
Merge branch 'main' into eculver/gha-deploy-fixes
eculver May 17, 2025
901995e
Add comment about production deploys being manual
eculver May 17, 2025
44abed2
Empty commit
eculver May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-chromadb.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ jobs:
// - This workflow finishes for A and deploys A to Chroma Cloud
// Chroma Cloud is now running A, but the last commit was B.
"environment": "staging",
"planes": "data,control"
"planes": "control,data"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency...

}
})

Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/trigger-deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ on:
push:
branches:
# main is not included here because it is handled by the release-chromadb.yaml workflow
# production deploys (release branches) are also not here because they are currently
# meant to be handled manually.
- rc/**-**-**
- release/**-**-**

jobs:
deploy:
Expand All @@ -25,7 +26,7 @@ jobs:
ref: 'main',
inputs: {
'planes': 'control,data',
environment: '${{ contains(github.ref, 'release/') && 'production' || 'staging' }}',
environment: 'staging',
'ignore-lock': true,
'oss-ref': '${{ github.ref_name }}',
'hosted-ref': '${{ github.ref_name }}'
Expand Down
Loading