-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[BLD] Do not trigger deploy on merge to release branches #4561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This PR modifies GitHub workflows to prevent automatic deployment when changes are merged to release branches. This makes deployment a manual step to avoid unintentional deploys when hotfixing the data plane. This summary was automatically generated by @propel-code-bot |
@@ -220,7 +220,7 @@ jobs: | |||
// - This workflow finishes for A and deploys A to Chroma Cloud | |||
// Chroma Cloud is now running A, but the last commit was B. | |||
"environment": "staging", | |||
"planes": "data,control" | |||
"planes": "control,data" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for consistency...
There is some issue with the action runners that is completely unrelated to this change. It seems to be persistent. I'm going to merge this as it has nothing to do with this change -- this does not change the "PR Checks" workflow. I'm hoping that it's something about this PR that is broken and that the merge commit will yield a green. |
Description of changes
This removes the
release/**
trigger from thetrigger-deploy
workflow so that deploys aren't created when hotfixes are merged to release branches. We want this to be a manual step for the time being to prevent unintentional deploys of the control plane when we are hotfixing the data plane.Test plan
Manual testing -- we will have to manually deploy changes after merging hotfixes to release branches.